FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: prepare markdown file for upcoming formatting/linting by Trott · Pull Request #40156 · nodejs/node · GitHub

/ node Public

doc: prepare markdown file for upcoming formatting/linting - #40156

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:test-md
Sep 22, 2021
Merged

doc: prepare markdown file for upcoming formatting/linting#40156
Trott merged 1 commit into
nodejs:masterfrom
Trott:test-md

Conversation

Trott commented Sep 19, 2021

Copy link
Copy Markdown
Member

No description provided.

Trott requested a review from aduh95 September 19, 2021 20:29
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 19, 2021
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 20, 2021
Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2021

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/40156
✔  Done loading data for nodejs/node/pull/40156
----------------------------------- PR info ------------------------------------
Title      doc: prepare markdown file for upcoming formatting/linting (#40156)
Author     Rich Trott  (@Trott)
Branch     Trott:test-md -> nodejs:master
Labels     test, author ready, needs-ci
Commits    1
 - doc: prepare markdown file for upcoming formatting/linting
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/40156
Reviewed-By: Antoine du Hamel 
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40156
Reviewed-By: Antoine du Hamel 
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 19 Sep 2021 20:29:28 GMT
   ✔  Approvals: 3
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40156#pullrequestreview-758188978
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40156#pullrequestreview-758347027
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40156#pullrequestreview-758696453
   ✔  Last GitHub Actions successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1259413001

github-actions Bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 21, 2021
PR-URL: nodejs#40156
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott commented Sep 22, 2021

Copy link
Copy Markdown
Member Author

Landed in f4a350d

Trott merged commit f4a350d into nodejs:master Sep 22, 2021
Trott deleted the test-md branch September 22, 2021 00:01
targos pushed a commit that referenced this pull request Oct 4, 2021
PR-URL: #40156
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL