FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update benchmarks README.md for upcoming linting/formatting by Trott · Pull Request #40158 · nodejs/node · GitHub

/ node Public

doc: update benchmarks README.md for upcoming linting/formatting - #40158

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:benchmark-md
Sep 22, 2021
Merged

doc: update benchmarks README.md for upcoming linting/formatting#40158
Trott merged 1 commit into
nodejs:masterfrom
Trott:benchmark-md

Conversation

Trott commented Sep 19, 2021

Copy link
Copy Markdown
Member

No description provided.

nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Sep 19, 2021
Trott changed the title doc: update benchamrks README.md for upcoming linting/formatting doc: update benchmarks README.md for upcoming linting/formatting Sep 19, 2021
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 20, 2021
Comment thread benchmark/README.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
| perf\_hooks | Benchmarks for the `perf_hooks` subsystem. |
| perf\_hooks | Benchmarks for the `perf_hooks` subsystem. |

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixed. Thanks. I'm pretty sure that consistent alignment of pipes in the text representation of tables is something that can be configured in the formatter, so I'll look into doing that.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Turns out it's the default with remark-gfm which we use in the linter, so this will happen automatically when we start using the linter for the formatter. I was omitting gfm when running remark on the command line, but I won't do that in subsequent PRs. Thanks again!

PR-URL: nodejs#40158
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott commented Sep 22, 2021

Copy link
Copy Markdown
Member Author

Landed in a6a5d4b

Trott merged commit a6a5d4b into nodejs:master Sep 22, 2021
Trott deleted the benchmark-md branch September 22, 2021 00:02
targos pushed a commit that referenced this pull request Oct 4, 2021
PR-URL: #40158
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. benchmark Issues and PRs related to the benchmark subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL