FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix typo error by xuchaobei · Pull Request #40187 · nodejs/node · GitHub

/ node Public

doc: fix typo error - #40187

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
xuchaobei:patch-1
Sep 24, 2021
Merged

doc: fix typo error#40187
aduh95 merged 1 commit into
nodejs:masterfrom
xuchaobei:patch-1

Conversation

Copy link
Copy Markdown
Contributor

No description provided.

nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Sep 23, 2021

Ayase-252 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice catch, thanks

xuchaobei changed the title fix typo error doc: fix typo error Sep 23, 2021
jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 23, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 23, 2021
aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 23, 2021
PR-URL: nodejs#40187
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

Landed in 5f3c1b6

aduh95 merged commit 5f3c1b6 into nodejs:master Sep 24, 2021
targos pushed a commit that referenced this pull request Oct 4, 2021
PR-URL: #40187
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants


Back | FazBrowse Home | New Git URL