FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: handle initEDRaw pkey failure by codebytere · Pull Request #40188 · nodejs/node · GitHub

/ node Public

crypto: handle initEDRaw pkey failure - #40188

Closed
codebytere wants to merge 2 commits into
nodejs:masterfrom
codebytere:handle-initedraw-failure
ConversationCommits (2)ChecksFiles changed
Closed

crypto: handle initEDRaw pkey failure#40188
codebytere wants to merge 2 commits into
nodejs:masterfrom
codebytere:handle-initedraw-failure

Conversation

codebytere commented Sep 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Refs electron/electron#31087.

It's possible that

node/src/crypto/crypto_keys.cc

Line 1106 in 4441c3e

EVPKeyPointer pkey(fn(id, nullptr, key_data.data(), key_data.size()));
will fail, and KeyObjectHandle::InitEDRaw will set the return value to false. This means that the data_ member will never be assigned. However, the return value of this function is never checked by any of its callsites, meaning that a keyObject is returned but that calling any functions on it, e.g. export or asymmetricKeyType will cause a nullptr crash when they try to access key->Data().

Fix this by checking the return value from handle.initEdRaw() and throwing an error on false.

I used the error from above the callsites but please let me know if there's another preferable one!

codebytere added the crypto Issues and PRs related to the crypto subsystem. label Sep 23, 2021
codebytere requested a review from jasnell September 23, 2021 11:49
nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 23, 2021
codebytere requested a review from tniessen September 23, 2021 11:51
codebytere force-pushed the handle-initedraw-failure branch from ab79e03 to 323cafb Compare September 23, 2021 11:51

This comment has been minimized.

Sign in to view
codebytere force-pushed the handle-initedraw-failure branch from 323cafb to b73c0a1 Compare September 24, 2021 10:16
panva removed the needs-ci PRs that need a full CI run. label Sep 24, 2021
panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 24, 2021

This comment has been minimized.

Sign in to view
panva requested changes Sep 24, 2021
View reviewed changes
Comment thread lib/internal/crypto/ec.js Outdated
codebytere force-pushed the handle-initedraw-failure branch from b73c0a1 to f7f01b6 Compare September 24, 2021 18:50
panva added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2021

This comment has been minimized.

Sign in to view
panva reviewed Sep 24, 2021
View reviewed changes
Comment thread lib/internal/crypto/ec.js Outdated
Update lib/internal/crypto/ec.js
ddb7253 
Co-authored-by: Filip Skokan <panva.ip@gmail.com>
github-actions Bot mentioned this pull request Sep 25, 2021
Open
17 tasks

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Sep 25, 2021 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40061/ 💛

jasnell pushed a commit that referenced this pull request Sep 25, 2021
crypto: handle initEDRaw pkey failure
17bb7b2 
PR-URL: #40188
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Sep 25, 2021

Copy link
Copy Markdown
Member

Landed in 17bb7b2

jasnell closed this Sep 25, 2021
codebytere deleted the handle-initedraw-failure branch September 25, 2021 14:51
github-actions Bot mentioned this pull request Sep 26, 2021
Open
21 tasks
This was referenced Sep 27, 2021
Open
Open
Open
Open
Open
Open
Open
github-actions Bot mentioned this pull request Oct 4, 2021
Open
22 tasks
targos pushed a commit that referenced this pull request Oct 4, 2021
crypto: handle initEDRaw pkey failure
2fa5e50 
PR-URL: #40188
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Oct 4, 2021
Merged
github-actions Bot mentioned this pull request Oct 5, 2021
Open
21 tasks
codebytere added a commit to electron/electron that referenced this pull request Oct 11, 2021
crypto: handle initEDRaw pkey failure
2ac9db6 
nodejs/node#40188
codebytere added a commit to electron/electron that referenced this pull request Oct 11, 2021
crypto: handle initEDRaw pkey failure
61d4f3b 
nodejs/node#40188
codebytere added a commit to electron/electron that referenced this pull request Oct 11, 2021
crypto: handle initEDRaw pkey failure
5c33b21 
nodejs/node#40188
codebytere added a commit to electron/electron that referenced this pull request Oct 11, 2021
crypto: handle initEDRaw pkey failure
3727b82 
nodejs/node#40188
codebytere added a commit to electron/electron that referenced this pull request Oct 13, 2021
crypto: handle initEDRaw pkey failure
9a27fc9 
nodejs/node#40188
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva approved these changes
jasnell jasnell approved these changes
tniessen Awaiting requested review from tniessen

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL