FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add version when diagnostics_channel APIs were added by Flarna · Pull Request #40208 · nodejs/node · GitHub

/ node Public

doc: add version when diagnostics_channel APIs were added - #40208

Closed
Flarna wants to merge 1 commit into
nodejs:masterfrom
Flarna:doc_diag-channel_created
ConversationCommits (1)ChecksFiles changed
Closed

doc: add version when diagnostics_channel APIs were added#40208
Flarna wants to merge 1 commit into
nodejs:masterfrom
Flarna:doc_diag-channel_created

Conversation

Flarna commented Sep 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Add a yaml section to document when diagnostics_channel APIs were introduced.

Refs.: #34895

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 24, 2021
Flarna force-pushed the doc_diag-channel_created branch 2 times, most recently from 3615a52 to d1e4736 Compare September 24, 2021 12:00
doc: add version when diagnostics_channel APIs were added
b70b0d6 
Add a yaml section to document when diagnostics_channel APIs were
introduced.
Flarna force-pushed the doc_diag-channel_created branch from d1e4736 to b70b0d6 Compare September 24, 2021 12:06
Flarna added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 24, 2021
Flarna requested a review from Qard September 24, 2021 12:15

tniessen commented Sep 24, 2021

Copy link
Copy Markdown
Member

I'm not quite sure how the module scoped <!--introduced_in=v15.1.0--> relates to this.

Qard commented Sep 24, 2021

Copy link
Copy Markdown
Member

As far as I understand it, the introduced_in thing is for telling the version changer thing at the top of the page what version to start its range at. It doesn't seem to support features introduced partway through the life of one version and then backported partway through the life of another.

Flarna commented Sep 25, 2021

Copy link
Copy Markdown
Member Author

I'm not quite sure how the module scoped <!--introduced_in=v15.1.0--> relates to this.

I don't know either. it's not visible if you browse the docs. At least the version matches so seem to be fine.

jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 25, 2021

github-actions Bot commented Sep 25, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

Flarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2021

github-actions Bot commented Sep 25, 2021

Copy link
Copy Markdown
Contributor

Landed in ae876d4...b0ef080

github-actions Bot closed this Sep 25, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 25, 2021
doc: add version when diagnostics_channel APIs were added
b0ef080 
Add a yaml section to document when diagnostics_channel APIs were
introduced.

PR-URL: #40208
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Flarna deleted the doc_diag-channel_created branch September 25, 2021 16:17
targos pushed a commit that referenced this pull request Oct 4, 2021
doc: add version when diagnostics_channel APIs were added
a68f91c 
Add a yaml section to document when diagnostics_channel APIs were
introduced.

PR-URL: #40208
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams mentioned this pull request Oct 4, 2021
Merged
Mesteery added the diagnostics_channel Issues and PRs related to diagnostics channel label Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Qard Qard approved these changes
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
tniessen tniessen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. diagnostics_channel Issues and PRs related to diagnostics channel doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL