FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix typo in fs by mscdex · Pull Request #40257 · nodejs/node · GitHub

/ node Public

doc: fix typo in fs - #40257

Closed
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:doc-fs-fix-typo
Closed

doc: fix typo in fs#40257
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:doc-fs-fix-typo

Conversation

mscdex commented Sep 29, 2021

Copy link
Copy Markdown
Contributor

The original text was "String form" meaning the string form of a path compared to other forms like a Buffer or URL object (as alluded to in the previous paragraph) was correct, however leaving "form" out entirely is slightly better and may confuse people less.

mscdex added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 29, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mscdex. Please 👍 to approve.

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2021

Copy link
Copy Markdown
Contributor

Landed in 5607de8...1798674

github-actions Bot closed this Sep 29, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 29, 2021
PR-URL: #40257
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
mscdex deleted the doc-fs-fix-typo branch September 29, 2021 17:18
targos pushed a commit that referenced this pull request Oct 4, 2021
PR-URL: #40257
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL