FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix typo in test/common/index.js by tniessen · Pull Request #40297 · nodejs/node · GitHub

/ node Public

test: fix typo in test/common/index.js - #40297

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
tniessen:test-typo-comparatively
Oct 3, 2021
Merged

test: fix typo in test/common/index.js#40297
aduh95 merged 1 commit into
nodejs:masterfrom
tniessen:test-typo-comparatively

Conversation

tniessen commented Oct 3, 2021

Copy link
Copy Markdown
Member

No description provided.

tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 3, 2021
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 3, 2021

github-actions Bot commented Oct 3, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed needs-ci PRs that need a full CI run. labels Oct 3, 2021
PR-URL: nodejs#40297
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 force-pushed the test-typo-comparatively branch from 50684cf to d0fa1e9 Compare October 3, 2021 14:20

aduh95 commented Oct 3, 2021

Copy link
Copy Markdown
Contributor

Landed in d0fa1e9

aduh95 merged commit d0fa1e9 into nodejs:master Oct 3, 2021
targos pushed a commit that referenced this pull request Oct 4, 2021
PR-URL: #40297
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
tniessen deleted the test-typo-comparatively branch October 7, 2021 16:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL