FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: fix regular expression to detect `/` and `\` by fasttime · Pull Request #40325 · nodejs/node · GitHub

/ node Public

lib: fix regular expression to detect / and \ - #40325

Closed
fasttime wants to merge 1 commit into
nodejs:masterfrom
fasttime:fix-40305
ConversationCommits (1)ChecksFiles changed
Closed

lib: fix regular expression to detect / and \#40325
fasttime wants to merge 1 commit into
nodejs:masterfrom
fasttime:fix-40305

Conversation

fasttime commented Oct 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Allow importing from file URLs with encoded commas. Forbid encoded backslashes. Fixes #40305.

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Oct 5, 2021
fasttime marked this pull request as ready for review October 5, 2021 05:43

targos commented Oct 5, 2021

Copy link
Copy Markdown
Member

@nodejs/modules

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2021

nodejs-github-bot commented Oct 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40155/

guybedford approved these changes Oct 5, 2021
View reviewed changes

guybedford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Many thanks, and apologies for the slip!

nodejs-github-bot commented Oct 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40161/

bmeck commented Oct 5, 2021

Copy link
Copy Markdown
Member

Since , is significant for data: we should add a test for that as well even if this codepath doesn't cover data: normally I could foresee a refactor accidentally mixing the 2.

guybedford commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

@bmeck this code path does apply to data URLs, in that data URLs that contain a percent encoded comma will no longer throw, even if that percent encoding is in the body of the data URL. On the other hand, percent encoded / and \\ in any position of a data URL, including the body, will always throw. One option here could be to separately special case data URLs in opting out of these validations for the body of the data URL. I think that should be a separate PR though.

bmeck commented Oct 5, 2021

Copy link
Copy Markdown
Member

@guybedford my main concern is how:

import(`data:text/javascript;x="${encodeURIComponent(',')}",export default 123`);

is interpreted and ensuring it works, otherwise we could just leave the , in the regexp in this PR rather than removing it if we just want to fix the slashes. I'd prefer we have a test for the data: impact if we change its behavior.

guybedford commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

@bmeck I believe right now your example would fail across all versions, where this PR fixes that.

guybedford commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

Ah, I see data: URLs have an early exit higher up in the resolver so don't hit this path. We should codify that into the spec as well, will post a PR.

guybedford commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

@bmeck since data URLs definitely never hit this path at all, I don't think there's any test coverage to apply here, are you ok with landing as is to get this fix in? I am working on a PR to clarify the data URL distinction in the spec as well as some other encoding cases.

bmeck commented Oct 5, 2021

Copy link
Copy Markdown
Member

@guybedford yea that is fine, though also note that Blob is up and coming

This was referenced Oct 6, 2021
Open
Open
This was referenced Oct 8, 2021
Open
Open
Open
Open

nodejs-github-bot commented Oct 20, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40384/

aduh95 mentioned this pull request Oct 22, 2021
Closed
aduh95 pushed a commit to aduh95/node that referenced this pull request Oct 22, 2021
lib: fix regular expression to detect / and \
a33a1a3 
PR-URL: nodejs#40325
Fixes: nodejs#40305
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
github-actions Bot mentioned this pull request Oct 23, 2021
Open
31 tasks
targos pushed a commit that referenced this pull request Oct 23, 2021
lib: fix regular expression to detect / and \
81cd7f3 
Fixes #40305

PR-URL: #40325
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
github-actions Bot mentioned this pull request Oct 24, 2021
Open
31 tasks
targos mentioned this pull request Nov 8, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Nov 23, 2021
lib: fix regular expression to detect / and \
881dd7b 
Fixes #40305

PR-URL: #40325
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
richardlau pushed a commit that referenced this pull request Nov 26, 2021
lib: fix regular expression to detect / and \
b5b66ef 
PR-URL: #40325
Backport-PR-URL: #40564
Fixes: #40305
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
richardlau pushed a commit that referenced this pull request Nov 26, 2021
lib: fix regular expression to detect / and \
8894bdd 
PR-URL: #40325
Backport-PR-URL: #40564
Fixes: #40305
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
richardlau mentioned this pull request Nov 26, 2021
Merged
BethGriggs added a commit that referenced this pull request Nov 30, 2021
2021-11-30, Version 16.13.1 'Gallium' (LTS)
88cfa36 
Notable changes:

- **deps**: upgrade npm to 8.1.2 (npm team)
  [#40643](#40643)
- **deps**: update c-ares to 1.18.1 (Richard Lau)
  [#40660](#40660)
- **doc**: add VoltrexMaster to collaborators (voltrexmaster)
  [#40566](#40566)
- **lib**: fix regular expression to detect \`/\` and \`\\\`
  (Francesco Trotta) [#40325](#40325)

PR-URL: #40974
BethGriggs added a commit that referenced this pull request Dec 1, 2021
2021-12-01, Version 16.13.1 'Gallium' (LTS)
12029ce 
Notable changes:

- **deps**: upgrade npm to 8.1.2 (npm team)
  [#40643](#40643)
- **deps**: update c-ares to 1.18.1 (Richard Lau)
  [#40660](#40660)
- **doc**: add VoltrexMaster to collaborators (voltrexmaster)
  [#40566](#40566)
- **lib**: fix regular expression to detect \`/\` and \`\\\`
  (Francesco Trotta) [#40325](#40325)

PR-URL: #40974
BethGriggs added a commit that referenced this pull request Dec 1, 2021
2021-12-01, Version 16.13.1 'Gallium' (LTS)
6f74010 
Notable changes:

- **deps**: upgrade npm to 8.1.2 (npm team)
  [#40643](#40643)
- **deps**: update c-ares to 1.18.1 (Richard Lau)
  [#40660](#40660)
- **doc**: add VoltrexMaster to collaborators (voltrexmaster)
  [#40566](#40566)
- **lib**: fix regular expression to detect \`/\` and \`\\\`
  (Francesco Trotta) [#40325](#40325)

PR-URL: #40974
richardlau pushed a commit that referenced this pull request Dec 14, 2021
lib: fix regular expression to detect / and \
243b2fb 
PR-URL: #40325
Backport-PR-URL: #40565
Fixes: #40305
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
richardlau mentioned this pull request Dec 15, 2021
Merged
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024
lib: fix regular expression to detect / and \
55dfacd 
PR-URL: nodejs/node#40325
Fixes: nodejs/node#40305
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
guybedford guybedford approved these changes
himself65 himself65 approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error importing ES module with an encoded comma in the URL

10 participants

Back | FazBrowse Home | New Git URL