doc, src: improve default read length - #40347
Closed
wbt wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Currently, specifying an `offset` without a `length` throws an ERR_OUT_OF_RANGE error. This provides a more sensible default. This change should only affect cases where no length is specified and a nonzero offset is, which are currently throwing errors.
Not 100% sure if this is all of them.
Copy link
Copy Markdown
Contributor
Author
|
Apologies that I hadn't read the commit message requirements until after making these two commits; GitHub does not make editing commit messages easy. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit sets the default length of bytes to read to a value
that doesn't throw an error in the absence of another optional option.
I'm not 100% sure if there are additional places in the code or
documentation which should also be updated due to repetition.