doc: n-api: out params for TypedArray info can be NULL - #40371
Closed
isaacbrodsky wants to merge 1 commit into
Closed
doc: n-api: out params for TypedArray info can be NULL#40371isaacbrodsky wants to merge 1 commit into
isaacbrodsky wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
VoltrexKeyva
reviewed
Oct 8, 2021
This is useful information to have for applications that don't need to read the other properties. The implementation checks for `nullptr`, see: https://github.com/nodejs/node/blob/master/src/js_native_api_v8.cc#L2879
Copy link
Copy Markdown
Contributor
Author
|
@VoltrexMaster lint should be fixed now, thanks |
Sorry, something went wrong.
legendecas
approved these changes
Oct 8, 2021
Copy link
Copy Markdown
Member
|
For whoever lands this: The commit message needs only one colon and the first thing after the colon should be an imperative verb. Maybe this? doc: indicate n-api out parameters that may be NULL Or something like that. @isaacbrodsky If you fell like saving someone a few keystrokes and making that change to the commit message on your patch-1 branch, that would be great. (But no worries if not.) |
Sorry, something went wrong.
tniessen
approved these changes
Oct 8, 2021
mhdawson
approved these changes
Oct 8, 2021
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
lpinca
approved these changes
Oct 8, 2021
Copy link
Copy Markdown
Member
|
To add to what @Trott wrote, commit message body should be wrapped at 72 characters per line. |
Sorry, something went wrong.
jasnell
approved these changes
Oct 9, 2021
mhdawson
pushed a commit
that referenced
this pull request
Oct 13, 2021
This is useful information to have for applications that don't need to read the other properties. The implementation checks for `nullptr`, see: https://github.com/nodejs/node/blob/master/src/js_native_api_v8.cc#L2879 PR-URL: #40371 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2 tasks
targos
pushed a commit
that referenced
this pull request
Nov 4, 2021
This is useful information to have for applications that don't need to read the other properties. The implementation checks for `nullptr`, see: https://github.com/nodejs/node/blob/master/src/js_native_api_v8.cc#L2879 PR-URL: #40371 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful information to have for applications that don't need to read the other properties. The implementation checks for nullptr, see:
node/src/js_native_api_v8.cc
Line 2879 in dbc91de