[v16.x backport] stream: implement streams to webstreams adapters - #40384
Closed
Mesteery wants to merge 1 commit into
Closed
[v16.x backport] stream: implement streams to webstreams adapters#40384Mesteery wants to merge 1 commit into
Mesteery wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Experimental adapters for the webstreams API Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#39134 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
approved these changes
Oct 9, 2021
targos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
node:internal/process/promises:246
triggerUncaughtException(err, true /* fromPromise */);
^
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected
Comparison {
+ code: 'ERR_STREAM_PREMATURE_CLOSE'
- code: 'ABORT_ERR'
}
at processTicksAndRejections (node:internal/process/task_queues:96:5) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: Error [ERR_STREAM_PREMATURE_CLOSE]: Premature close
at new NodeError (node:internal/errors:371:5)
at PassThrough.onclose (node:internal/streams/end-of-stream:135:30)
at PassThrough.emit (node:events:402:35)
at emitCloseNT (node:internal/streams/destroy:138:10)
at processTicksAndRejections (node:internal/process/task_queues:82:21) {
code: 'ERR_STREAM_PREMATURE_CLOSE'
},
expected: { code: 'ABORT_ERR' },
operator: 'rejects'
}
/cc @nodejs/streams @jasnell |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
also Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
at Proxy.mustCall (/home/iojs/build/workspace/node-test-commit-linux/test/common/index.js:352:10)
at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/test/parallel/test-whatwg-webstreams-adapters-to-readablestream.js:34:31)
at Module._compile (node:internal/modules/cjs/loader:1101:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
at Module.load (node:internal/modules/cjs/loader:981:32)
at Function.Module._load (node:internal/modules/cjs/loader:822:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
at node:internal/main/run_main_module:17:47
|
Sorry, something went wrong.
benjamingr
approved these changes
Oct 9, 2021
mcollina
approved these changes
Oct 9, 2021
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I was more asking for help, since there are a lot of failing tests (probably because parts of this depend on a semver-major change) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Since, indeed, it depends on a semver-major (#38505). It is not possible to backport the PR to 16.x release line, right? |
Sorry, something went wrong.
This was referenced Oct 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #39134.