src,fs: remove ToLocalChecked() call from fs::AfterMkdirp() - #40386
Closed
RaisinTen wants to merge 1 commit into
Closed
src,fs: remove ToLocalChecked() call from fs::AfterMkdirp()#40386RaisinTen wants to merge 1 commit into
RaisinTen wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This comment has been minimized.
jasnell
reviewed
Oct 9, 2021
Comment thread
src/node_file.cc
Outdated
jasnell
approved these changes
Oct 9, 2021
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with a nit
Sorry, something went wrong.
This merges the `IsEmpty()` call and the `ToLocalChecked()` call into a single `ToLocal()` call. Signed-off-by: Darshan Sen <darshan.sen@postman.com>
RaisinTen
force-pushed
the
src,fs/remove-ToLocalChecked-call-from-fs-AfterMkdirp
branch
from
4f8ebfc to
b6b8f6e
Compare
October 9, 2021 15:42
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
approved these changes
Oct 11, 2021
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 20, 2021
This merges the `IsEmpty()` call and the `ToLocalChecked()` call into a single `ToLocal()` call. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40386 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
RaisinTen
deleted the
src,fs/remove-ToLocalChecked-call-from-fs-AfterMkdirp
branch
October 20, 2021 15:08
targos
pushed a commit
that referenced
this pull request
Oct 23, 2021
This merges the `IsEmpty()` call and the `ToLocalChecked()` call into a single `ToLocal()` call. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40386 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 23, 2021
This merges the `IsEmpty()` call and the `ToLocalChecked()` call into a single `ToLocal()` call. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40386 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges the IsEmpty() call and the ToLocalChecked() call into a
single ToLocal() call.
Signed-off-by: Darshan Sen darshan.sen@postman.com