FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src,crypto: remove `AllocatedBuffer` from `crypto_cipher.cc` by RaisinTen · Pull Request #40400 · nodejs/node · GitHub

/ node Public

src,crypto: remove AllocatedBuffer from crypto_cipher.cc - #40400

Closed
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:src,crypto/remove-AllocatedBuffer-from-crypto_cipher.cc
Closed

src,crypto: remove AllocatedBuffer from crypto_cipher.cc#40400
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:src,crypto/remove-AllocatedBuffer-from-crypto_cipher.cc

Conversation

Copy link
Copy Markdown
Member

Signed-off-by: Darshan Sen darshan.sen@postman.com

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Oct 10, 2021

This comment has been minimized.

Comment thread src/crypto/crypto_cipher.cc Outdated
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
RaisinTen force-pushed the src,crypto/remove-AllocatedBuffer-from-crypto_cipher.cc branch from 9841890 to 869adb8 Compare October 11, 2021 13:23
RaisinTen requested a review from addaleax October 11, 2021 13:24

This comment has been minimized.

RaisinTen added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed needs-ci PRs that need a full CI run. labels Oct 13, 2021

This comment has been minimized.

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Contributor

Landed in aef8abb...e1d598c

github-actions Bot closed this Oct 20, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 20, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40400
Reviewed-By: Anna Henningsen <anna@addaleax.net>
RaisinTen deleted the src,crypto/remove-AllocatedBuffer-from-crypto_cipher.cc branch October 20, 2021 15:08
targos pushed a commit that referenced this pull request Oct 23, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40400
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 23, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40400
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs mentioned this pull request Nov 26, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL