FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: V8: cherry-pick 422dc378a1da by rayw000 · Pull Request #40450 · nodejs/node · GitHub

/ node Public

deps: V8: cherry-pick 422dc378a1da - #40450

Closed
rayw000 wants to merge 1 commit into
nodejs:masterfrom
rayw000:cherry-pick-v8-422dc37
Closed

deps: V8: cherry-pick 422dc378a1da#40450
rayw000 wants to merge 1 commit into
nodejs:masterfrom
rayw000:cherry-pick-v8-422dc37

Conversation

rayw000 commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

Original commit message:

[deserialization] Remove unnecessarily limit on buffer size

1. Now there is no serializer/deserializer-specific buffer size limit.
2. Update AUTHORS

Ref: https://github.com/nodejs/node/issues/40059

Change-Id: Iad4c6d8f68a91ef21d3c404fb7945949e69ad9e2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3170411
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77084}

Refs: v8/v8@422dc37

Related to: #40243
Fix: #40059

Original commit message:

    [deserialization] Remove unnecessarily limit on buffer size

    1. Now there is no serializer/deserializer-specific buffer size limit.
    2. Update AUTHORS

    Ref: #40059

    Change-Id: Iad4c6d8f68a91ef21d3c404fb7945949e69ad9e2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3170411
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77084}

Refs: v8/v8@422dc37
nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 14, 2021

nodejs-github-bot commented Oct 14, 2021
edited by targos
Loading

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

rayw000 commented Oct 19, 2021

Copy link
Copy Markdown
Contributor Author

Hi @targos @cjihrig

I can't tell how the four failing tests relate to this PR. Could you help me to make this PR landable? Thank you!

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2021

targos commented Oct 19, 2021

Copy link
Copy Markdown
Member

They don't. I requested a new CI run.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2021

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

rayw000 commented Oct 23, 2021

Copy link
Copy Markdown
Contributor Author

Hi @targos

If you land this PR, please also land #40243 . They are all for issue #40059. Thanks.

targos pushed a commit that referenced this pull request Oct 23, 2021
Original commit message:

    [deserialization] Remove unnecessarily limit on buffer size

    1. Now there is no serializer/deserializer-specific buffer size limit.
    2. Update AUTHORS

    Ref: #40059

    Change-Id: Iad4c6d8f68a91ef21d3c404fb7945949e69ad9e2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3170411
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77084}

Refs: v8/v8@422dc37

PR-URL: #40450
Fixes: #40059
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos commented Oct 23, 2021

Copy link
Copy Markdown
Member

Landed in c83f47f

targos closed this Oct 23, 2021
targos pushed a commit that referenced this pull request Oct 23, 2021
Original commit message:

    [deserialization] Remove unnecessarily limit on buffer size

    1. Now there is no serializer/deserializer-specific buffer size limit.
    2. Update AUTHORS

    Ref: #40059

    Change-Id: Iad4c6d8f68a91ef21d3c404fb7945949e69ad9e2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3170411
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77084}

Refs: v8/v8@422dc37

PR-URL: #40450
Fixes: #40059
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rayw000 deleted the cherry-pick-v8-422dc37 branch October 23, 2021 07:21
targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 24, 2021
Original commit message:

    [deserialization] Remove unnecessarily limit on buffer size

    1. Now there is no serializer/deserializer-specific buffer size limit.
    2. Update AUTHORS

    Ref: #40059

    Change-Id: Iad4c6d8f68a91ef21d3c404fb7945949e69ad9e2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3170411
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77084}

Refs: v8/v8@422dc37

PR-URL: #40450
Fixes: #40059
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs mentioned this pull request Nov 26, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document (or fix?) v8.deserialize' 2gb limitation for input buffer

4 participants


Back | FazBrowse Home | New Git URL