| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Our governance process is such that someone needs to either agree to be moved to emeritus or else the TSC has to act to move them to emeritus. @yhwang Are you OK being moved to emeritus at this time? |
Sorry, something went wrong.
|
Adding blocked and tsc-agenda labels. They can both be removed if yhwang approves the change. |
Sorry, something went wrong.
|
How did the second commit get here? GitHub marks it as "first-time contributor" and wants approval to run workflows. And then there is #40498 which appears to be a duplicate of this PR. |
Sorry, something went wrong.
|
I approve both commits. :-D |
Sorry, something went wrong.
There was a problem hiding this comment.
The change for openssl seems to just remove all of the licencing details. That seems wrong.
Sorry, something went wrong.
Ah, license-builder.sh needs an update. Coming in a few minutes, I think.... |
Sorry, something went wrong.
|
@mhdawson License update corrected. PTAL. |
Sorry, something went wrong.
There was a problem hiding this comment.
The README changes LGTM.
Sorry, something went wrong.
|
I think the openssl license updates should be separated -- they would make the PR need dont-land-on labels to prevent landing on the release lines that still contain openssl 1.1.1. |
Sorry, something went wrong.
|
The README changes LGTM, but agree the change to the licence should be broken out into its own PR. |
Sorry, something went wrong.
|
Fine, be all reasonable. I'll move the license change to a separate PR and then remove it from here. |
Sorry, something went wrong.
|
License stuff moved to #40540. This PR is now just the automated collaborator change. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
sorry for the late response, I'm good with the move. |
Sorry, something went wrong.
Commit Queue failed- Loading data for nodejs/node/pull/40464 ✔ Done loading data for nodejs/node/pull/40464 ----------------------------------- PR info ------------------------------------ Title meta: move one or more collaborators to emeritus (#40464) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:create-or-update-pull-request-action -> nodejs:master Labels doc, meta, tsc-agenda Commits 1 - meta: move one or more collaborators to emeritus Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40464 Reviewed-By: Michaël Zasso Reviewed-By: Rich Trott Reviewed-By: Michael Dawson Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel Reviewed-By: Danielle Adams Reviewed-By: Richard Lau Reviewed-By: Сковорода Никита Андреевич Reviewed-By: Beth Griggs Reviewed-By: Myles Borins Reviewed-By: Franziska Hinkelmann Reviewed-By: Yihong Wang ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40464 Reviewed-By: Michaël Zasso Reviewed-By: Rich Trott Reviewed-By: Michael Dawson Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel Reviewed-By: Danielle Adams Reviewed-By: Richard Lau Reviewed-By: Сковорода Никита Андреевич Reviewed-By: Beth Griggs Reviewed-By: Myles Borins Reviewed-By: Franziska Hinkelmann Reviewed-By: Yihong Wang -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 15 Oct 2021 04:12:13 GMT ✔ Approvals: 12 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-780811991 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-780820059 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-785699421 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-784747905 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-784875981 ✔ - Danielle Adams (@danielleadams) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786199342 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786199444 ✔ - Сковорода Никита Андреевич (@ChALkeR) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786206079 ✔ - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786206332 ✔ - Myles Borins (@MylesBorins) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786210296 ✔ - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786320852 ✔ - Yihong Wang (@yhwang): https://github.com/nodejs/node/pull/40464#pullrequestreview-786347207 ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1370508576 |
Sorry, something went wrong.
PR-URL: #40464 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Yihong Wang <yh.wang@ibm.com>
PR-URL: #40464 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Yihong Wang <yh.wang@ibm.com>
PR-URL: #40464 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Yihong Wang <yh.wang@ibm.com>
| Back | FazBrowse Home | New Git URL |
This PR was generated by tools/find-inactive-collaborators.yml.