FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: consolidate AUTHORS entries for cxreg by Trott · Pull Request #40490 · nodejs/node · GitHub

/ node Public

meta: consolidate AUTHORS entries for cxreg - #40490

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:authors-do
Oct 19, 2021
Merged

meta: consolidate AUTHORS entries for cxreg#40490
Trott merged 1 commit into
nodejs:masterfrom
Trott:authors-do

Conversation

Trott commented Oct 17, 2021

Copy link
Copy Markdown
Member

No description provided.

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 17, 2021

Trott commented Oct 17, 2021

Copy link
Copy Markdown
Member Author

@cxreg This change removes your nodesource.com email address and leaves your pobox.com address in AUTHORS. If you'd prefer the opposite, let me know. Thanks!

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 17, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 17, 2021
Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2021
PR-URL: nodejs#40490
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Trott removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2021

Trott commented Oct 19, 2021

Copy link
Copy Markdown
Member Author

Landed in 2bed031

Trott merged commit 2bed031 into nodejs:master Oct 19, 2021
Trott deleted the authors-do branch October 19, 2021 13:11
targos pushed a commit that referenced this pull request Oct 23, 2021
PR-URL: #40490
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 23, 2021
PR-URL: #40490
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
BethGriggs mentioned this pull request Nov 26, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL