deps,build,tools: fix openssl-is-fips for ninja builds - #40518
Closed
danbev wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Currently using the --openssl-is-fips configuration option in combination with --ninja is broken. This commit fixes two issues, one being an issue with the linker/version script path variable. The second is that the locations of built artifacts that differ for ninja and make. ninja: $ ./configure --openssl-is-fips --ninja $ ninja -C out/Release $ ./node --enable-fips -p 'crypto.getFips()' 1 make: $ ./configure --openssl-is-fips $ make -j8 $ ./node --enable-fips -p 'crypto.getFips()' 1 Refs: nodejs#40509
Copy link
Copy Markdown
Member
|
Note that this fixes the path issue seen in #40421, but the macro-redefined warning is still emitted: In file included from <built-in>:391:
<command line>:26:9: warning: 'OPENSSLDIR' macro redefined [-Wmacro-redefined]
#define OPENSSLDIR "/System/Library/OpenSSL/"
^
<command line>:25:9: note: previous definition is here
#define OPENSSLDIR "/Users/targos/git/nodejs/node/out/Release/obj.target/deps/openssl"
^
1 warning generated.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
27 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
richardlau
approved these changes
Oct 20, 2021
BethGriggs
approved these changes
Oct 20, 2021
Copy link
Copy Markdown
Contributor
|
non-contributor +1, running into this trying to build Node.js in a Docker image :) |
Sorry, something went wrong.
30 tasks
danbev
added a commit
that referenced
this pull request
Oct 21, 2021
Currently using the --openssl-is-fips configuration option in combination with --ninja is broken. This commit fixes two issues, one being an issue with the linker/version script path variable. The second is that the locations of built artifacts that differ for ninja and make. ninja: $ ./configure --openssl-is-fips --ninja $ ninja -C out/Release $ ./node --enable-fips -p 'crypto.getFips()' 1 make: $ ./configure --openssl-is-fips $ make -j8 $ ./node --enable-fips -p 'crypto.getFips()' 1 PR-URL: #40518 Refs: #40509 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
This was referenced Oct 22, 2021
targos
pushed a commit
that referenced
this pull request
Oct 23, 2021
Currently using the --openssl-is-fips configuration option in combination with --ninja is broken. This commit fixes two issues, one being an issue with the linker/version script path variable. The second is that the locations of built artifacts that differ for ninja and make. ninja: $ ./configure --openssl-is-fips --ninja $ ninja -C out/Release $ ./node --enable-fips -p 'crypto.getFips()' 1 make: $ ./configure --openssl-is-fips $ make -j8 $ ./node --enable-fips -p 'crypto.getFips()' 1 PR-URL: #40518 Refs: #40509 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
This was referenced Oct 24, 2021
gengjiawen
reviewed
Dec 29, 2021
Comment thread
tools/gyp/pylib/gyp/__init__.py
| 'out', default_variables['build_type'])) | ||
| else: | ||
| default_variables.setdefault("PRODUCT_DIR_ABS", os.path.join(output_dir, | ||
| default_variables['build_type'])) |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@danbev should this sticks to CONFIGURATION_NAME, I run into some problems when directly run this files.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently using the --openssl-is-fips configuration option in
combination with --ninja is broken.
This commit fixes two issues, one being an issue with the linker/version
script path variable. The second is that the locations of built
artifacts that differ for ninja and make.
ninja:
make:
Refs: #40509