doc: fix environment variable settings for ccache - #40550
Merged
Trott merged 2 commits intoOct 24, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This comment has been minimized.
GeoffreyBooth
approved these changes
Oct 21, 2021
GeoffreyBooth
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Closes #40542
Sorry, something went wrong.
aduh95
approved these changes
Oct 21, 2021
lpinca
approved these changes
Oct 21, 2021
mscdex
reviewed
Oct 22, 2021
Comment thread
BUILDING.md
Outdated
Comment on lines
524
to
525
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Should we be dropping these?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Should we be dropping these?
ccache has a reasonable default for cache_dir so that removes the necessity to set a cache_dir explicitly. Ref: https://ccache.dev/manual/4.3.html#config_cache_dir
max_size default is 5Gb, so we don't need the step that explicitly sets it to 5Gb as well. Ref: https://ccache.dev/manual/4.3.html#config_max_size
Sorry, something went wrong.
targos
reviewed
Oct 22, 2021
Comment thread
BUILDING.md
Outdated
Copy link
Copy Markdown
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/40550 ✔ Done loading data for nodejs/node/pull/40550 ----------------------------------- PR info ------------------------------------ Title doc: fix environment variable settings for ccache (#40550) Author Rich Trott (@Trott) Branch Trott:build-ccache -> nodejs:master Labels doc, build, author ready Commits 3 - doc: fix environment variable settings for ccache - doc: format BUILDING.md - doc: simplify ccache instructions Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40550 Fixes: https://github.com/nodejs/node/issues/40542 Reviewed-By: Geoffrey Booth Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40550 Fixes: https://github.com/nodejs/node/issues/40542 Reviewed-By: Geoffrey Booth Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 21 Oct 2021 17:15:20 GMT ✔ Approvals: 3 ✔ - Geoffrey Booth (@GeoffreyBooth): https://github.com/nodejs/node/pull/40550#pullrequestreview-785998018 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40550#pullrequestreview-786016926 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40550#pullrequestreview-786090196 ✔ Last GitHub Actions successful ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 40550 From https://github.com/nodejs/node * branch refs/pull/40550/merge -> FETCH_HEAD ✔ Fetched commits as 40d890d31d6f..b57e2b0a64be -------------------------------------------------------------------------------- Auto-merging BUILDING.md [master e7817f7d32] doc: fix environment variable settings for ccache Author: Rich Trott Date: Thu Oct 21 10:06:49 2021 -0700 1 file changed, 12 insertions(+) Auto-merging BUILDING.md The previous cherry-pick is now empty, possibly due to conflict resolution. If you wish to commit it anyway, use:https://github.com/nodejs/node/actions/runs/1377942911 |
Sorry, something went wrong.
macOS requires `cc` and `c++` rather than `gcc` and `g++`. Closes: nodejs#40542 PR-URL: nodejs#40550 Fixes: nodejs#40542 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
`ccache` has reasonable defaults for `max_size` and `cache_dir` so remove instructions to set those things explicitly. Change fenced code from `console` to `bash` for easier copy/paste. PR-URL: nodejs#40550 Fixes: nodejs#40542 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Copy link
Copy Markdown
Member
Author
|
Landed in 40d890d...31d7d6c |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
`ccache` has reasonable defaults for `max_size` and `cache_dir` so remove instructions to set those things explicitly. Change fenced code from `console` to `bash` for easier copy/paste. PR-URL: #40550 Fixes: #40542 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
`ccache` has reasonable defaults for `max_size` and `cache_dir` so remove instructions to set those things explicitly. Change fenced code from `console` to `bash` for easier copy/paste. PR-URL: #40550 Fixes: #40542 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS requires cc and c++ rather than gcc and g++.
Closes: #40542