FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

policy: fix message for invalid manifest specifier by Trott · Pull Request #40574 · nodejs/node · GitHub

/ node Public

policy: fix message for invalid manifest specifier - #40574

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:manifest-fix
Oct 25, 2021
ConversationCommits (1)ChecksFiles changed
Merged

policy: fix message for invalid manifest specifier#40574
Trott merged 1 commit into
nodejs:masterfrom
Trott:manifest-fix

Conversation

Trott commented Oct 23, 2021

Copy link
Copy Markdown
Member

Add test for invalid manifest specifier and fix the error message
which is missing a space ("singletrailing" instead of
"single trailing").

nodejs-github-bot added needs-ci PRs that need a full CI run. policy Issues and PRs related to the policy subsystem. labels Oct 23, 2021
Trott requested a review from bmeck October 23, 2021 05:42
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2021

This comment has been minimized.

Sign in to view
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2021

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 23, 2021

nodejs-github-bot commented Oct 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40420/

Mesteery removed the needs-ci PRs that need a full CI run. label Oct 23, 2021

nodejs-github-bot commented Oct 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40423/

nodejs-github-bot commented Oct 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40427/

github-actions Bot mentioned this pull request Oct 24, 2021
Open
31 tasks

nodejs-github-bot commented Oct 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40438/

nodejs-github-bot commented Oct 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40440/

nodejs-github-bot commented Oct 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40444/

nodejs-github-bot commented Oct 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40446/

nodejs-github-bot commented Oct 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40449/

nodejs-github-bot commented Oct 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40451/

github-actions Bot mentioned this pull request Oct 25, 2021
Open
24 tasks

nodejs-github-bot commented Oct 25, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40456/

nodejs-github-bot commented Oct 25, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40457/

nodejs-github-bot commented Oct 25, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40458/

nodejs-github-bot commented Oct 25, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40459/

nodejs-github-bot commented Oct 25, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40460/

nodejs-github-bot commented Oct 25, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40463/

nodejs-github-bot commented Oct 25, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40465/

nodejs-github-bot commented Oct 25, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40467/

policy: fix message for invalid manifest specifier
070b54a 
Add test for invalid manifest specifier and fix the error message
which is missing a space ("singletrailing" instead of
"single trailing").

PR-URL: nodejs#40574
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>

Trott commented Oct 25, 2021

Copy link
Copy Markdown
Member Author

Landed in 070b54a

Trott merged commit 070b54a into nodejs:master Oct 25, 2021
Trott deleted the manifest-fix branch October 25, 2021 05:42
This was referenced Oct 26, 2021
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 6, 2021
policy: fix message for invalid manifest specifier
b320387 
Add test for invalid manifest specifier and fix the error message
which is missing a space ("singletrailing" instead of
"single trailing").

PR-URL: #40574
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
targos mentioned this pull request Nov 8, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
policy: fix message for invalid manifest specifier
dab574e 
Add test for invalid manifest specifier and fix the error message
which is missing a space ("singletrailing" instead of
"single trailing").

PR-URL: #40574
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
Lxxyx Lxxyx approved these changes
aduh95 aduh95 approved these changes
+2 more reviewers
bmeck bmeck approved these changes
VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. policy Issues and PRs related to the policy subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL