FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: consolidate AUTHORS entries for brettkiefer by Trott · Pull Request #40599 · nodejs/node · GitHub

/ node Public

meta: consolidate AUTHORS entries for brettkiefer - #40599

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:authors-bk
Closed

meta: consolidate AUTHORS entries for brettkiefer#40599
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:authors-bk

Conversation

Trott commented Oct 25, 2021

Copy link
Copy Markdown
Member

No description provided.

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 25, 2021

Trott commented Oct 25, 2021

Copy link
Copy Markdown
Member Author

@brettkiefer This uses a .mailmap entry to use your gmail.com address in favor of your trello.com address in AUTHORS. If you'd prefer the other way around, please leave a comment. Thanks!

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 25, 2021

This comment has been minimized.

Trott requested review from lpinca and tniessen October 28, 2021 00:18
Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Oct 28, 2021

Trott commented Oct 28, 2021

Copy link
Copy Markdown
Member Author

This is the last of these consolidation PRs. Needs some reviews. Help?

Trott requested a review from jasnell October 28, 2021 15:35
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 28, 2021
Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2021

Copy link
Copy Markdown
Contributor

Landed in e937662...babd73c

github-actions Bot closed this Oct 30, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 30, 2021
PR-URL: #40599
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Trott deleted the authors-bk branch October 30, 2021 00:38
targos pushed a commit that referenced this pull request Nov 6, 2021
PR-URL: #40599
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
PR-URL: #40599
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
BethGriggs mentioned this pull request Nov 26, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL