tools: fix bug in prefer-primordials ESLint rule - #40628
Merged
aduh95 merged 1 commit intoNov 4, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aduh95
force-pushed
the
fix-prefer-primordials-bug
branch
2 times, most recently
from
1e1822b to
899670a
Compare
October 27, 2021 14:52
targos
approved these changes
Oct 27, 2021
targos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM based on added tests.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
VoltrexKeyva
approved these changes
Oct 27, 2021
30 tasks
jasnell
approved these changes
Oct 28, 2021
This comment has been minimized.
This comment has been minimized.
33 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
aduh95
added a commit
to nodejs/node-auto-test
that referenced
this pull request
Oct 29, 2021
commit 958a05db7e7d9ec62e3aea119aad10c7cfd39ba6
Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Wed Oct 27 16:17:05 2021 +0200
tools: fix bug in `prefer-primordials` ESLint rule
Refs: nodejs/node#40622
PR-URL: nodejs/node#40628
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
35 tasks
This comment has been minimized.
34 tasks
This comment has been minimized.
This was referenced Nov 1, 2021
aduh95
force-pushed
the
fix-prefer-primordials-bug
branch
from
6d552c8 to
a63bf2c
Compare
November 2, 2021 08:26
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Nov 3, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Nov 5, 2021
This was referenced Nov 7, 2021
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #40622