FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: simplify and fix commit queue by targos · Pull Request #40742 · nodejs/node · GitHub

/ node Public

tools: simplify and fix commit queue - #40742

Merged
aduh95 merged 4 commits into
nodejs:masterfrom
targos:gh-no-curl
Nov 7, 2021
Merged

tools: simplify and fix commit queue#40742
aduh95 merged 4 commits into
nodejs:masterfrom
targos:gh-no-curl

Conversation

targos commented Nov 6, 2021

Copy link
Copy Markdown
Member

/cc @nodejs/actions

nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 6, 2021
Comment thread .github/workflows/commit-queue.yml Outdated
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Comment thread tools/actions/commit-queue.sh Outdated
aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 6, 2021

github-actions Bot commented Nov 6, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

To fix the CQ failing to push, we need to use the nodejs-github-bot token when merging, as the gituhb-actions bot user is not allowed to push to this repo (see conversation in #40734).

Comment thread tools/actions/commit-queue.sh Outdated
Comment thread .github/workflows/commit-queue.yml Outdated
targos and others added 2 commits November 6, 2021 18:11
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos changed the title tools: use gh CLI for CI and commit queue jobs tools: simplify and fix commit queue Nov 7, 2021
aduh95 merged commit 8731193 into nodejs:master Nov 7, 2021

aduh95 commented Nov 7, 2021

Copy link
Copy Markdown
Contributor

Landed in 8731193

aduh95 commented Nov 7, 2021

Copy link
Copy Markdown
Contributor
GraphQL error: Your token has not been granted the required scopes to execute this query. The 'login' field requires one of the following scopes: ['read:org'], but your token has only been granted the: ['read:user', 'repo', 'user:email', 'workflow'] scopes. Please modify your token's scopes at: https://github.com/settings/tokens.

https://github.com/nodejs/node/runs/4131235476?check_suite_focus=true

aduh95 commented Nov 7, 2021

Copy link
Copy Markdown
Contributor

It looks like we need to either go back to using both tokens, or update the permissions of the bot's token. I'll open an issue on nodejs/admin to request the latter, but on the mean time the CQ is broken.

targos added a commit that referenced this pull request Nov 8, 2021
Use `gh` CLI for CI and commit queue jobs, and use the correct token
to merge PRs.

PR-URL: #40742
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
targos mentioned this pull request Nov 8, 2021

Copy link
Copy Markdown
Contributor

I temporarily disabled the CQ action until we fix the issue.

targos deleted the gh-no-curl branch November 8, 2021 20:36
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
Use `gh` CLI for CI and commit queue jobs, and use the correct token
to merge PRs.

PR-URL: #40742
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
BethGriggs mentioned this pull request Nov 26, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL