doc: Grammar/typo fix for https.Agent section - #4075
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Could you make this:
Alternatively, without an Agent.
Sorry, something went wrong.
There was a problem hiding this comment.
I tried to keep it to the grammar fix only. When changing the wording, I'd rather use something along these lines:
Alternatively, opt out of connection pooling.
That's how agent: false is documented above and describes the intent/effect instead of an implementation detail.
Sorry, something went wrong.
There was a problem hiding this comment.
How about this, to make it more clear what is different:
Alternatively, opt out of connection pooling by not using an Agent.
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks! Updated.
Sorry, something went wrong.
PR-URL: #4075 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Thanks! LGTM and landed in 8eb153d. |
Sorry, something went wrong.
PR-URL: #4075 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #4075 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #4075 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #4075 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#4075 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Changed to use imperative to be consistent with "use a custom Agent" above.