doc: add fspromises mkdir example - #40843
Merged
nodejs-github-bot merged 8 commits intoJun 12, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Tierney Cyren <hello@bnb.im>
This comment has been minimized.
Signed-off-by: Tierney Cyren <hello@bnb.im>
edsadr
approved these changes
Nov 18, 2021
aduh95
approved these changes
Nov 18, 2021
VoltrexKeyva
approved these changes
Nov 18, 2021
jasnell
reviewed
Nov 20, 2021
Comment thread
doc/api/fs.md
Outdated
jasnell
approved these changes
Nov 25, 2021
bnb
commented
Dec 13, 2021
Comment thread
doc/api/fs.md
Outdated
Signed-off-by: Tierney Cyren <hello@bnb.im>
Copy link
Copy Markdown
Contributor
Author
|
@aduh95 PTAL. Should be good now. Worth noting that I also added a slash at the end of the CJS example, again to be consistent. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. back 👍🏻 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
(also apologies for the delay, ngl I forgot this was open) |
Sorry, something went wrong.
aduh95
requested changes
Jun 11, 2022
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
All the docs are now using node: prefix.
Sorry, something went wrong.
aduh95
reviewed
Jun 11, 2022
Comment thread
doc/api/fs.md
Outdated
aduh95
reviewed
Jun 11, 2022
Comment thread
doc/api/fs.md
Outdated
|
|
||
| } | ||
|
|
||
| makeDirectory(); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
nit: instead of a try/catch, I would put a .catch(console.error): calling an async function without awaiting it or having a catch handler should be frowned upon imho.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
would you want me to move the MJS example to be a function and do the same, or should that continue using top-level await in a try/catch?
Sorry, something went wrong.
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
aduh95
approved these changes
Jun 12, 2022
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
Signed-off-by: Tierney Cyren <hello@bnb.im> PR-URL: #40843 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Signed-off-by: Tierney Cyren <hello@bnb.im> PR-URL: #40843 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Signed-off-by: Tierney Cyren <hello@bnb.im> PR-URL: #40843 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Signed-off-by: Tierney Cyren <hello@bnb.im> PR-URL: nodejs/node#40843 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an example to the fsPromises mkdir doc. Includes both cjs and mjs versions, because we should support both imo.