FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: cleanup eos by ronag · Pull Request #40998 · nodejs/node · GitHub

/ node Public

stream: cleanup eos - #40998

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
nxtedition:eof-cleanup
Dec 1, 2021
ConversationCommits (1)ChecksFiles changed
Merged

stream: cleanup eos#40998
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
nxtedition:eof-cleanup

Conversation

ronag commented Nov 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Improve readability

ronag commented Nov 28, 2021

Copy link
Copy Markdown
Member Author

@nodejs/streams

ronag added the stream Issues and PRs related to the stream subsystem. label Nov 28, 2021
nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 28, 2021
ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Nov 28, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2021

This comment has been minimized.

Sign in to view
BridgeAR approved these changes Nov 28, 2021
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

ronag added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 28, 2021
lpinca approved these changes Nov 28, 2021
View reviewed changes

lpinca left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with a comment. It shouldn't cause issues in practice but ¯_(ツ)_/¯

Comment thread lib/internal/streams/end-of-stream.js
(options.readable !== false && isReadableNodeStream(stream));
const writable = options.writable ||
(options.writable !== false && isWritableNodeStream(stream));
const readable = options.readable ?? isReadableNodeStream(stream);

lpinca Nov 28, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Behavior is different for some falsy values.

mcollina approved these changes Nov 28, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

github-actions Bot mentioned this pull request Nov 29, 2021
Open
27 tasks
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2021

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Nov 29, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41216/

BridgeAR added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 1, 2021
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 1, 2021
nodejs-github-bot merged commit 40a52bd into nodejs:master Dec 1, 2021

nodejs-github-bot commented Dec 1, 2021

Copy link
Copy Markdown
Collaborator

Landed in 40a52bd

github-actions Bot mentioned this pull request Dec 3, 2021
Open
36 tasks
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
stream: cleanup eos
513305c 
PR-URL: #40998
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Dec 14, 2021
Merged

danielleadams commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

@ronag do you mind opening a backport PR for this to v16.x-staging? When pulling it for the release, it causes some failing tests.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL