util: determine object types in C++ - #4100
Merged
cjihrig merged 0 commit intoDec 2, 2015
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM if CI is happy |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
CI looks good. Some Windows failures of flakey tests. Will land tomorrow. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM. You could maybe DRY it a little using x-macros but that's not strictly necessary and can be done in another PR. |
Sorry, something went wrong.
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Dec 2, 2015
Determine object types of regular expressions, Dates, Maps, and Sets in the C++ layer instead of depending on toString() behavior in JavaScript. PR-URL: nodejs#4100 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Copy link
Copy Markdown
Member
|
While not strictly necessary, I think marking this one for LTS would make sense. |
Sorry, something went wrong.
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Dec 4, 2015
The Is* type checking functions in node_util.cc are mostly the same boilerplate. This commit defines them using a macro. Refs: nodejs#4100 PR-URL: nodejs#4118 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig
added a commit
that referenced
this pull request
Dec 5, 2015
Determine object types of regular expressions, Dates, Maps, and Sets in the C++ layer instead of depending on toString() behavior in JavaScript. PR-URL: #4100 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced Dec 8, 2015
Closed
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Jan 7, 2016
Determine object types of regular expressions, Dates, Maps, and Sets in the C++ layer instead of depending on toString() behavior in JavaScript. PR-URL: nodejs#4100 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Jan 7, 2016
The Is* type checking functions in node_util.cc are mostly the same boilerplate. This commit defines them using a macro. Refs: nodejs#4100 PR-URL: nodejs#4118 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Conflicts: src/node_util.cc
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
Determine object types of regular expressions, Dates, Maps, and Sets in the C++ layer instead of depending on toString() behavior in JavaScript. PR-URL: #4100 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Determine object types of regular expressions, Dates, Maps, and Sets in the C++ layer instead of depending on toString() behavior in JavaScript. PR-URL: nodejs#4100 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
The Is* type checking functions in node_util.cc are mostly the same boilerplate. This commit defines them using a macro. Refs: nodejs#4100 PR-URL: nodejs#4118 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Contributor
|
@jdalton experiencing issues with this? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Nope. Just cc'ing folks in (@arv and @bmeurer) that were interested. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Determine object types of regular expressions, Dates, Maps, and Sets in the C++ layer instead of depending on toString() behavior in JavaScript.