Add NODE_RTLD_GLOBAL to control library loading - #4105
Closed
Y-- wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
`NODE_RTLD_GLOBAL=true` set `RTLD_GLOBAL` flag when loading module
Copy link
Copy Markdown
Contributor
|
If your PR requires changes to libuv (files in deps/uv), could you open a PR there first? |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Sure, I will do that right now. Thanks |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks. Closing this for now. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
I've created a PR in libuv there : libuv/libuv#635 |
Sorry, something went wrong.
3 tasks
refack
pushed a commit
that referenced
this pull request
Sep 8, 2017
* add constants for dlopen flags, which are needed for dlopen's flag passing. * introduce an optional parameter for process.dlopen(), allowing to pass dlopen flags (using values from os.constants.dlopen). If no flags are passed, the default behavior is to load the library with RTLD_LAZY (perform lazy binding) and RTLD_LOCAL (symbols are available only locally). PR-URL: #12794 Refs: #4105 Refs: libuv/libuv#1331 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Sep 13, 2017
* add constants for dlopen flags, which are needed for dlopen's flag passing. * introduce an optional parameter for process.dlopen(), allowing to pass dlopen flags (using values from os.constants.dlopen). If no flags are passed, the default behavior is to load the library with RTLD_LAZY (perform lazy binding) and RTLD_LOCAL (symbols are available only locally). PR-URL: nodejs#12794 Refs: nodejs#4105 Refs: libuv/libuv#1331 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the environment variable NODE_RTLD_GLOBAL to true set RTLD_GLOBAL flag when loading module.
This pull request is motivated by the fact that dlopen does not have the same behavior on MacOS X and Linux (cf. dlopen man page) :
RTLD_LOCAL This is the converse of RTLD_GLOBAL, and the default if neither flag is specified.I was not sure what name would be the best to use for this purpose, so this is a first suggestion, but I'd be happy to change them. Also, I've implemented that as an opt-in mode, with as few changes as I could, but I'd be also happy to extend the idea and provide more flexibility.
Note : I'm no Windows expert, so I was not sure how what to do for this implementation.
Many thanks in advance for considering this patch.