deps: upgrade to npm 2.14.12 by zkat · Pull Request #4110 · nodejs/node · GitHub

Hiii!

This PR includes two releases:

The main thing to note is a hopefully welcome update to our licensing to clarify scope of both the open source side and the registry TOS. There's a further clarification coming later this week, so we're not done with that bit yet -- so keep an eye out for v2.14.13.

This PR supersedes #4003, but have a look-see over there for some discussion. That PR should be closeable, though. #4033 was closed because I made it against the wrong branch. Sorry about that. :)

r: @jasnell
r: @Fishrock123
r: @chrisdickinson
r: @thealphanerd

I was unable to apply the patch with git am but it cleanly cherry-picked onto v4.x-staging

make test-npm gives two errors.

1st as expected:

test/tap/prune.js ................................... 16/17
  npm install
  not ok Should not get data on stderr: WARN engine underscore@1.3.1: wanted: {"node":"*"} (current: {"node":"4.2.3-pre","npm":"2.14.12"})
    at:
      file: test/tap/prune.js
      line: 57
      column: 7
    stack: |
      test/tap/prune.js:57:7
      f (node_modules/once/once.js:17:25)
      ChildProcess.<anonymous> (test/common-tap.js:56:5)
      maybeClose (internal/child_process.js:818:16)
      Socket.<anonymous> (internal/child_process.js:319:11)
      Pipe._onclose (net.js:469:12)

2nd also happens with v3.5.0 (I think?), not sure what's up here:

test/tap/circular-dep.js .............................. 8/9
  installing a package that depends on the current package
  not ok no error output
    at:
      file: test/tap/circular-dep.js
      line: 48
      column: 9
    stack: |
      test/tap/circular-dep.js:48:9
      f (node_modules/once/once.js:17:25)
      ChildProcess.<anonymous> (test/common-tap.js:56:5)
      maybeClose (internal/child_process.js:818:16)
      Socket.<anonymous> (internal/child_process.js:319:11)
      Pipe._onclose (net.js:469:12)

I was seeing both of those myself fwiw

@thealphanerd @Fishrock123 This is the thing where you have to set node to be a release, not a prerelease. See #4003 (comment)

@zkat ah ok I didn't realize both were from that. :)

LGTM

@thealphanerd Would you prefer to land it?

@Fishrock123 sec. After #3959 (comment), I have updated the LICENSE file for node accordingly, so please re-review.

@jasnell See new commit! Is this alright now?

@zkat ... I haven't had a chance to review the entire PR so I can't give an LGTM but the new commit is exactly what I needed! Thanks!

I have confirmed using diff that the resulting LICENSE is identical to that found on https://github.com/npm/npm/blob/master/LICENSE

LGTM

LGTM. This shouldn't land until the corresponding PR for master also lands tho.

derp.. nevermind.. sigh. I keep forgetting that master and v5.x are on npm3. sigh.

Tests passed, for the record. cc @jasnell

Edit: with node_version.h modified to look like a release

@zkat, this PR is not landing cleanly on v4.x-staging for me for some reason. Can you take a moment to do a quick rebase and update then I'll get it landed.

@jasnell git am -3

PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

@zkat nevermind :-) @Fishrock123 .. thanks :-)

Landed in fff8132 and 4f8d557

PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Maintenance Update Notable changes * Roughly 78% of the commits are documentation and test improvements * domains: - Fix handling of uncaught exceptions (Julien Gilli) [#3884](#3884) * deps: - Upgrade to npm 2.14.12 (Kat Marchán) [#4110](#4110) - Backport 819b40a from V8 upstream (Michaël Zasso) [#3938](#3938) - Updated node LICENSE file with new npm license (Kat Marchán) [#4110](#4110)

PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Maintenance Update Notable changes * Roughly 78% of the commits are documentation and test improvements * domains: - Fix handling of uncaught exceptions (Julien Gilli) [#3884](#3884) * deps: - Upgrade to npm 2.14.12 (Kat Marchán) [#4110](#4110) - Backport 819b40a from V8 upstream (Michaël Zasso) [#3938](#3938) - Updated node LICENSE file with new npm license (Kat Marchán) [#4110](#4110)

PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Maintenance Update Notable changes * Roughly 78% of the commits are documentation and test improvements * domains: - Fix handling of uncaught exceptions (Julien Gilli) [#3884](#3884) * deps: - Upgrade to npm 2.14.12 (Kat Marchán) [#4110](#4110) - Backport 819b40a from V8 upstream (Michaël Zasso) [#3938](#3938) - Updated node LICENSE file with new npm license (Kat Marchán) [#4110](#4110)

Maintenance Update Notable changes * Roughly 78% of the commits are documentation and test improvements * domains: - Fix handling of uncaught exceptions (Julien Gilli) [nodejs#3884](nodejs#3884) * deps: - Upgrade to npm 2.14.12 (Kat Marchán) [nodejs#4110](nodejs#4110) - Backport 819b40a from V8 upstream (Michaël Zasso) [nodejs#3938](nodejs#3938) - Updated node LICENSE file with new npm license (Kat Marchán) [nodejs#4110](nodejs#4110)

deps: upgrade to npm 2.14.12

56c2274

Fishrock123 added the npm Issues and PRs related to the npm client dependency or the npm registry. label Dec 1, 2015

deps: Updated node LICENSE file with new npm license

c41ba9e

jasnell pushed a commit that referenced this pull request Dec 3, 2015

deps: upgrade to npm 2.14.12

fff8132

PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell closed this Dec 3, 2015

jasnell added the land-on-v4.x label Dec 3, 2015

MylesBorins added land-on-v4.x and removed lts-landed-on-v4.x labels Dec 17, 2015

jasnell mentioned this pull request Dec 17, 2015

Release 4.2.4 Planning #4321

Closed

zkat added a commit that referenced this pull request Dec 17, 2015

deps: upgrade to npm 2.14.12

08be311

PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

zkat added a commit that referenced this pull request Dec 17, 2015

deps: upgrade to npm 2.14.12

3dd90dd

PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell mentioned this pull request Dec 17, 2015

v4.2.4 Release Proposal #4336

Closed

zkat added a commit that referenced this pull request Dec 21, 2015

deps: upgrade to npm 2.14.12

51c9059

PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

zkat added a commit that referenced this pull request Dec 23, 2015

deps: upgrade to npm 2.14.12

810f76e

PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Starefossen mentioned this pull request Jan 4, 2016

NPM is 2.14 not 3.5.2 (using node:4.2-wheezy image) nodejs/docker-node#82

Closed

zkat mentioned this pull request Jan 29, 2016

deps: upgrade npm to 3.6.0 #4958

Closed

wraithgar deleted the npm-2.14.12 branch June 26, 2025 15:40

deps: upgrade to npm 2.14.12 by zkat · Pull Request #4110 · nodejs/node · GitHub

Uh oh!

Uh oh!

deps: upgrade to npm 2.14.12 - #4110

deps: upgrade to npm 2.14.12#4110zkat wants to merge 2 commits intonodejs:v4.x-stagingnodejs/node:v4.x-stagingfrom npm:npm-2.14.12npm/node:npm-2.14.12Copy head branch name to clipboard

Conversation

zkat commented Dec 1, 2015

Uh oh!

MylesBorins commented Dec 1, 2015

Uh oh!

Fishrock123 commented Dec 2, 2015

Uh oh!

MylesBorins commented Dec 2, 2015

Uh oh!

zkat commented Dec 2, 2015

Uh oh!

Fishrock123 commented Dec 2, 2015

Uh oh!

zkat commented Dec 2, 2015

Uh oh!

jasnell commented Dec 2, 2015

Uh oh!

MylesBorins commented Dec 2, 2015

Uh oh!

jasnell commented Dec 3, 2015

Uh oh!

jasnell commented Dec 3, 2015

Uh oh!

Fishrock123 commented Dec 3, 2015

Uh oh!

jasnell commented Dec 3, 2015

Uh oh!

Fishrock123 commented Dec 3, 2015

Uh oh!

jasnell commented Dec 3, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

deps: upgrade to npm 2.14.12#4110
zkat wants to merge 2 commits into
nodejs:v4.x-stagingfrom
npm:npm-2.14.12