doc: url.format - true slash postfix behaviour - #4119
Conversation
Sorry, something went wrong.
Change url.format's references to slash postfixing to reflect true behaviour (it only automatically postfixes slashes to the slashedProtocols when host is present). Fixes: nodejs#3361
|
I don't think we should document broken behaviour, see #3361 (comment). |
Sorry, something went wrong.
|
Well... the current behavior ought to be documented and if it's broken, it ought be fixed ;-) Until it's fixed, it definitely should be documented tho |
Sorry, something went wrong.
|
Right, you have a point. We can land this and then possible follow up with a breaking change that removes it again. LGTM |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
|
@silverwind once this lands I'll probably submit another PR doing that, will have to add a few tests to test-url (which has gotten quite large, probably a refactor into separate files might be warranted too) |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
|
May I land this? :) |
Sorry, something went wrong.
Change url.format's references to slash postfixing to reflect true behaviour (it only automatically postfixes slashes to the slashedProtocols when host is present). Fixes: #3361 PR-URL: #4119 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Change url.format's references to slash postfixing to reflect true behaviour (it only automatically postfixes slashes to the slashedProtocols when host is present). Fixes: #3361 PR-URL: #4119 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Change url.format's references to slash postfixing to reflect true behaviour (it only automatically postfixes slashes to the slashedProtocols when host is present). Fixes: #3361 PR-URL: #4119 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Change url.format's references to slash postfixing to reflect true behaviour (it only automatically postfixes slashes to the slashedProtocols when host is present). Fixes: #3361 PR-URL: #4119 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Change url.format's references to slash postfixing to reflect true behaviour (it only automatically postfixes slashes to the slashedProtocols when host is present). Fixes: nodejs#3361 PR-URL: nodejs#4119 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Change url.format's references to slash postfixing to reflect
true behaviour (it only automatically postfixes slashes to the
slashedProtocols when host is present).
Fixes: #3361
Also ccing to #4101