build: add loong64 configure - #41323
Merged
nodejs-github-bot merged 1 commit intoJan 18, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
targos
approved these changes
Dec 28, 2021
tniessen
approved these changes
Dec 28, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
cc @nodejs/build |
Sorry, something went wrong.
rvagg
reviewed
Jan 3, 2022
Comment thread
configure.py
| 'android', 'aix', 'cloudabi') | ||
| valid_arch = ('arm', 'arm64', 'ia32', 'mips', 'mipsel', 'mips64el', 'ppc', | ||
| 'ppc64', 'x32','x64', 'x86', 'x86_64', 's390x', 'riscv64') | ||
| 'ppc64', 'x32','x64', 'x86', 'x86_64', 's390x', 'riscv64', |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
once upon a time these entries were sorted, it's not critical but maybe while you're in here you could fix up these last 3 entries
Sorry, something went wrong.
mhdawson
approved these changes
Jan 4, 2022
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
richardlau
approved these changes
Jan 4, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Jan 17, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mmarchini
approved these changes
Jan 18, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Jan 19, 2022
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
PR-URL: #41323 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v8 had been add loong64 backend, this commit add loong64 build configure.