FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: improve strictly by yorkie · Pull Request #4138 · nodejs/node · GitHub

/ node Public

doc: improve strictly - #4138

Closed
yorkie wants to merge 1 commit into
nodejs:masterfrom
yorkie:patch-2
ConversationCommits (1)ChecksFiles changed
Closed

doc: improve strictly#4138
yorkie wants to merge 1 commit into
nodejs:masterfrom
yorkie:patch-2

Conversation

yorkie commented Dec 3, 2015

Copy link
Copy Markdown
Contributor

Just improve this document when reading it :-)

cjihrig commented Dec 3, 2015

Copy link
Copy Markdown
Contributor

LGTM

silverwind reviewed Dec 3, 2015
View reviewed changes
Comment thread doc/api/child_process.markdown Outdated

silverwind Dec 3, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Double space after period is not significant in rendered markdown and we use it in a few other places. Maybe leave out this change?

yorkie Dec 3, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sure :-)

jasnell commented Dec 3, 2015

Copy link
Copy Markdown
Member

LGTM

yorkie commented Dec 3, 2015

Copy link
Copy Markdown
Contributor Author

Removed the double spaces change and did resolve the conflicts :-)

mscdex added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Dec 3, 2015

JungMinu commented Dec 4, 2015

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Dec 4, 2015
doc: improve child_process.markdown wording
cc2ceb6 
PR-URL: #4138
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Dec 4, 2015

Copy link
Copy Markdown
Member

Landed in cc2ceb6

@yorkie ... I notice that in your commits, your name appears just as "yorkie". Is that how you would like your name to appear in the commit history or would you like your full name "Yorkie Liu" displayed? If you'd like your full name listed, can I ask you to run git config --global user.name "Yorkie Liu" to make sure that your git commits pick up your full name instead?

jasnell closed this Dec 4, 2015
yorkie deleted the patch-2 branch December 5, 2015 05:41

yorkie commented Dec 5, 2015

Copy link
Copy Markdown
Contributor Author

@jasnell the nickname "yorkie" is good to me, thank you.

rvagg pushed a commit that referenced this pull request Dec 5, 2015
doc: improve child_process.markdown wording
0cd4a52 
PR-URL: #4138
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 8, 2015
Closed
Merged
rvagg mentioned this pull request Dec 17, 2015
Closed
MylesBorins pushed a commit that referenced this pull request Dec 29, 2015
doc: improve child_process.markdown wording
f526071 
PR-URL: #4138
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
doc: improve child_process.markdown wording
39364c4 
PR-URL: #4138
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
doc: improve child_process.markdown wording
84825bc 
PR-URL: nodejs#4138
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Mar 18, 2020
Open
Open
Open
This was referenced Mar 18, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jul 13, 2021
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL