Stress test CI: https://ci.nodejs.org/job/node-stress-single-test/311/

Edit: Passed. Now let's try to get a bad run on master... heh. https://ci.nodejs.org/job/node-stress-single-test/313/

Trying stress tests again but this time with -J --repeat 10 -j 16 --repeat 128.

Current (expected to fail): https://ci.nodejs.org/job/node-stress-single-test/314/ https://ci.nodejs.org/job/node-stress-single-test/315/

This PR (expected to pass): ...will run once we see failures above...

Tbh I don't know that we've seen this fail on Win10 ever. Definitely older versions but I haven't been able to get those to run in node-stress-single-test.

Trying some of the others https://ci.nodejs.org/job/node-stress-single-test/316/

Edit: Trying again... https://ci.nodejs.org/job/node-stress-single-test/317/

Edit2: I guess most recently this actually failed on CentOS so... https://ci.nodejs.org/job/node-stress-single-test/318/

I have no clue about our build systems but most of these node-stress-single-test instances aren't working :(

I have no clue about our build systems but most of these node-stress-single-test instances aren't working :(

We could approve the PR on principle, I suppose.

I have no clue about our build systems but most of these node-stress-single-test instances aren't working :(

Looks like the stress job didn’t have the -gcc8 variants for centos7 added to the selectable configurations (we wouldn’t expect earlier versions to be able to compile current master). Also centos7-64 isn’t currently covered by https://github.com/nodejs/build/blob/master/jenkins/scripts/select-compiler.sh so isn’t selecting the right compiler either. I can look at sorting this out but it’ll be after the security releases.

This needs a rebase.

No longer needed IIUC: #48575