deps: make node-gyp fetch .lib from correct url - #415
Closed
bnoordhuis wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The .lib files at nodejs.org are at /dist/v1.2.3/node.lib and /dist/v1.2.3/x64/node.lib but on iojs.org, they are located at /dist/v1.2.3/win-x86/node.lib and /dist/v1.2.3/win-x64/node.lib respectively. Update the download URLs.
Copy link
Copy Markdown
Contributor
|
That doesn't really cut it. See #422 |
Sorry, something went wrong.
This was referenced Mar 7, 2020
This was referenced Oct 4, 2022
This was referenced Oct 25, 2022
This was referenced Feb 14, 2023
This was referenced Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .lib files at nodejs.org are at /dist/v1.2.3/node.lib and
/dist/v1.2.3/x64/node.lib but on iojs.org, they are located at
/dist/v1.2.3/win-x86/node.lib and /dist/v1.2.3/win-x64/node.lib
respectively. Update the download URLs.
R=@piscisaureus, /cc @seishun