tools: add missing .PHONY and .NOTPARALLEL targets in Makefile - #41515
Merged
nodejs-github-bot merged 1 commit intoJan 18, 2022
Merged
tools: add missing .PHONY and .NOTPARALLEL targets in Makefile#41515nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
richardlau
approved these changes
Jan 14, 2022
This comment has been minimized.
RaisinTen
approved these changes
Jan 14, 2022
RaisinTen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM but also running CI on this as this file is listed here -
node/doc/guides/collaborator-guide.md
Line 240 in 4dd1f42
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Jan 17, 2022
yashLadha
approved these changes
Jan 18, 2022
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
PR-URL: #41515 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yash Ladha <yash@yashladha.in>
danielleadams
pushed a commit
that referenced
this pull request
Feb 26, 2022
PR-URL: #41515 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yash Ladha <yash@yashladha.in>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
PR-URL: #41515 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yash Ladha <yash@yashladha.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was frustrated that this command didn't work: