doc: remove statement about (EC)DHE performance - #41528
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Author
|
cc @nodejs/crypto |
Sorry, something went wrong.
Trott
approved these changes
Jan 15, 2022
addaleax
approved these changes
Jan 15, 2022
benjamingr
approved these changes
Jan 15, 2022
benjamingr
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
All these changes are really good 🙇
Sorry, something went wrong.
tniessen
added a commit
that referenced
this pull request
Jan 16, 2022
This statement is misleading in that it says "key generation is expensive". ECDHE key generation (over the elliptic curves that are commonly used for TLS) is insanely fast compared to most other types of key generation. This statement is irrelevant for TLS 1.3, which requires (EC)DHE. Even if this statement is somewhat true for TLS 1.2, it does not justify discouraging the use of (EC)DHE. PR-URL: #41528 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Copy link
Copy Markdown
Member
Author
|
Landed in 986cf3b. Thanks @benjamingr and thanks all for reviewing! |
Sorry, something went wrong.
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
This statement is misleading in that it says "key generation is expensive". ECDHE key generation (over the elliptic curves that are commonly used for TLS) is insanely fast compared to most other types of key generation. This statement is irrelevant for TLS 1.3, which requires (EC)DHE. Even if this statement is somewhat true for TLS 1.2, it does not justify discouraging the use of (EC)DHE. PR-URL: #41528 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 26, 2022
This statement is misleading in that it says "key generation is expensive". ECDHE key generation (over the elliptic curves that are commonly used for TLS) is insanely fast compared to most other types of key generation. This statement is irrelevant for TLS 1.3, which requires (EC)DHE. Even if this statement is somewhat true for TLS 1.2, it does not justify discouraging the use of (EC)DHE. PR-URL: #41528 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.