test: add missing await in fs-rm/fs-rmdir tests - #41545
Closed
bcoe wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
iansu
approved these changes
Jan 15, 2022
iansu
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for looking into this Ben.
Sorry, something went wrong.
aduh95
approved these changes
Jan 15, 2022
This comment has been minimized.
richardlau
approved these changes
Jan 15, 2022
Mesteery
approved these changes
Jan 15, 2022
VoltrexKeyva
approved these changes
Jan 15, 2022
lpinca
approved these changes
Jan 15, 2022
cjihrig
approved these changes
Jan 15, 2022
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Jan 16, 2022
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nit on the commit message: The first word after the subsystem is supposed to be an imperative mood verb. So maybe this?
test: add missing await in fs-rm/fs-rmdir tests
Sorry, something went wrong.
RaisinTen
approved these changes
Jan 16, 2022
Noticed that a few assertions were not being awaited, this could potentially be leading to flakiness in tmp cleanup. Refs: nodejs#41201
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mhdawson
approved these changes
Jan 17, 2022
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
mhdawson
pushed a commit
that referenced
this pull request
Jan 17, 2022
Noticed that a few assertions were not being awaited, this could potentially be leading to flakiness in tmp cleanup. Refs: #41201 PR-URL: #41545 Refs: #41201 Reviewed-By: Ian Sutherland <ian@iansutherland.ca> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
16 tasks
This was referenced Jan 19, 2022
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
Noticed that a few assertions were not being awaited, this could potentially be leading to flakiness in tmp cleanup. Refs: #41201 PR-URL: #41545 Refs: #41201 Reviewed-By: Ian Sutherland <ian@iansutherland.ca> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This was referenced Feb 18, 2022
danielleadams
pushed a commit
that referenced
this pull request
Feb 26, 2022
Noticed that a few assertions were not being awaited, this could potentially be leading to flakiness in tmp cleanup. Refs: #41201 PR-URL: #41545 Refs: #41201 Reviewed-By: Ian Sutherland <ian@iansutherland.ca> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that a few assertions were not being awaited, this could
potentially be leading to flakiness in tmp cleanup.
Refs: #41201