FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: increase maximum line length to 120 characters by Trott · Pull Request #41586 · nodejs/node · GitHub

/ node Public

tools: increase maximum line length to 120 characters - #41586

Merged
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
Trott:max-len-120
Jan 21, 2022
Merged

tools: increase maximum line length to 120 characters#41586
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
Trott:max-len-120

Conversation

Trott commented Jan 19, 2022

Copy link
Copy Markdown
Member

No description provided.

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 19, 2022

Copy link
Copy Markdown
Member

Alternative: #41509
Alternative: #41536

Copy link
Copy Markdown
Member

Should this also apply to C++ sources and/or Markdown for consistency? (I'm not saying it's a good idea, but I am curious if the arguments for doing this in JavaScript are really specific to JavaScript.)

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

Trott commented Jan 19, 2022

Copy link
Copy Markdown
Member Author

Should this also apply to C++ sources and/or Markdown for consistency? (I'm not saying it's a good idea, but I am curious if the arguments for doing this in JavaScript are really specific to JavaScript.)

I'd prefer to treat each one separately so that decisions about one don't get complicated by considerations that only apply in one of the other contexts.

It might also be good to treat this as an experiment. If anyone is hesitant about increasing the limit, then maybe they'd be comfortable with just trying it for a few months and then deciding if we've had to give a lot of line-length nits or not.

But here's my take anyway on C++ and markdown:

  • The last time I programmed C++ on anything more than an occasional as-needed basis was around 20 years ago so I don't have an opinion there.

  • I can go either way with Markdown, but I think I favor eliminating the line breaks there too. All the same IDE (and markdown editor) arguments apply, and the argument that it will greatly simplify diffs applies much more strongly for prose than for code.

jasnell commented Jan 19, 2022

Copy link
Copy Markdown
Member

Increasing the c++ limit to 120 works for me.

bnb commented Jan 19, 2022
edited
Loading

Copy link
Copy Markdown
Contributor

I can go either way with Markdown, but I think I favor eliminating the line breaks there too. All the same IDE (and markdown editor) arguments apply, and the argument that it will greatly simplify diffs applies much more strongly for prose than for code.

Massively favor eliminating line breaks. In general, it seems that the ecosystem has adopted this as a standard, and it's extremely strange for us to be an outlier.

Copy link
Copy Markdown
Member

Massively favor eliminating line breaks. In general, it seems that the ecosystem has adopted this as a standard, and it's extremely strange for us to be an outlier.

On a side note, I suspect that most of the ecosystem doesn't need to backport documentation changes to multiple release lines with diverging commit histories, so they are probably less concerned about the increased number of conflicts and the reduced usefulness of git operations such as git blame.

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2022
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 21, 2022

This comment has been minimized.

Trott added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 21, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2022

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2022
nodejs-github-bot merged commit 870044f into nodejs:master Jan 21, 2022

Copy link
Copy Markdown
Collaborator

Landed in 870044f

Trott deleted the max-len-120 branch January 21, 2022 15:29
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
PR-URL: #41586
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
PR-URL: #41586
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
PR-URL: #41586
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
PR-URL: #41586
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
PR-URL: #41586
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
iamamanporwal added a commit to iamamanporwal/gexus-prod that referenced this pull request Aug 23, 2026
The previous deploy (1cf105f) failed its own postbuild verification on
Vercel — correctly. On Linux, nf3 nests version-conflicted deps as symlinks
*inside* store packages (google-auth-library/node_modules/gaxios and 21
friends), and fs.cpSync({ dereference: true }) only dereferences the
top-level path: nested links are recreated as links (nodejs/node#41586), so
the "materialized" tree still dangled. Windows never showed it because nf3's
junction layout keeps every link top-level, which is exactly why the local
verification passed while Vercel's failed.

The copy is now hand-rolled: copyReal() stats through symlinks at every
depth, so the output contains none regardless of layout. Verified in a clean
node:24 container from a tarball of this tree: npm ci + VERCEL=1 build exit
0, 19 links materialized, `find -type l` = 0, and the function artifact
serves / at 200 and /api/available-models at 200 in the same container.

Also makes the Sentry sourcemap upload non-fatal via errorHandler. The
plugin's default is to throw and kill the build on any upload failure — a
wrong org slug, an expired token, a Sentry outage. Observability must never
take down a deploy. Exercised in the same container with deliberately
invalid SENTRY_* values: three 401s from Sentry, three warnings in the log,
build exit 0, and zero .map files left in the output.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants


Back | FazBrowse Home | New Git URL