crypto: remove wildcard options for checkEmail - #41599
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: nodejs#41571
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
bnb
approved these changes
Jan 19, 2022
bnb
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
+1 if they truly have no effect
Sorry, something went wrong.
17 tasks
Copy link
Copy Markdown
Member
Author
To elaborate, these four options only affect how OpenSSL's X509_check_host handles *.example.com, a*.example.com, *b.example.com, etc. For email addresses, X.509 uses the RFC 822 mailbox syntax, which does not permit any of these wildcard patterns, and OpenSSL's X509_check_email will ignore wildcards regardless of whether these options are set or not :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
cc @nodejs/crypto |
Sorry, something went wrong.
19 tasks
17 tasks
panva
approved these changes
Jan 22, 2022
panva
pushed a commit
that referenced
this pull request
Jan 22, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
This was referenced Jan 23, 2022
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 28, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
Wildcard options do not affect X509_check_email. Refs: openssl/openssl#17536 Refs: #41571 PR-URL: #41599 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wildcard options do not affect X509_check_email.
Refs: openssl/openssl#17536
Refs: #41571