deps: upgrade to V8 4.7.80.25 - #4160
Closed
ofrobots wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Pick up the latest patch-level from V8 stable. This includes the following fix: * v8/v8@c408ea7 Make AstRawString deduplication encoding-agnostic. BUG=v8:4450 LOG=N R=hablich@chromium.org TBR=hablich@chromium.org Review URL: https://codereview.chromium.org/1494293003 See also: nodejs#4128
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
First CI had failure on windows which passed on the second CI: https://ci.nodejs.org/job/node-test-pull-request/928/. |
Sorry, something went wrong.
ofrobots
added a commit
that referenced
this pull request
Dec 5, 2015
Pick up the latest patch-level from V8 stable. This includes the following fix: * v8/v8@c408ea7 Make AstRawString deduplication encoding-agnostic. BUG=v8:4450 LOG=N R=hablich@chromium.org TBR=hablich@chromium.org Review URL: https://codereview.chromium.org/1494293003 See also: #4128 PR-URL: #4160 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
This was referenced Dec 8, 2015
Copy link
Copy Markdown
Member
|
Applying the label dont-land-on-v5.x — @nodejs/v8 would you mind labeling your PRs with this if it shouldn't got on v5.x but it's technically not semver-major? That way we can strip them out when looking at the differences and what needs to be merged. |
Sorry, something went wrong.
Closed
Closed
vkurchatkin
added a commit
that referenced
this pull request
Dec 23, 2015
Original commit message: Make AstRawString deduplication encoding-agnostic. R=jkummerow@chromium.org BUG=v8:4450 LOG=N Review URL: https://codereview.chromium.org/1411103006 Cr-Commit-Position: refs/heads/master@{#31624} Ref: #4160 PR-URL: #4128 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
vkurchatkin
added a commit
that referenced
this pull request
Jan 7, 2016
Original commit message: Make AstRawString deduplication encoding-agnostic. R=jkummerow@chromium.org BUG=v8:4450 LOG=N Review URL: https://codereview.chromium.org/1411103006 Cr-Commit-Position: refs/heads/master@{#31624} Ref: #4160 PR-URL: #4128 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
Original commit message: Make AstRawString deduplication encoding-agnostic. R=jkummerow@chromium.org BUG=v8:4450 LOG=N Review URL: https://codereview.chromium.org/1411103006 Cr-Commit-Position: refs/heads/master@{#31624} Ref: #4160 PR-URL: #4128 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Pick up the latest patch-level from V8 stable. This includes the following fix: * v8/v8@c408ea7 Make AstRawString deduplication encoding-agnostic. BUG=v8:4450 LOG=N R=hablich@chromium.org TBR=hablich@chromium.org Review URL: https://codereview.chromium.org/1494293003 See also: nodejs#4128 PR-URL: nodejs#4160 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
This was referenced Jul 23, 2021
This was referenced Jul 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick up the latest patch-level from V8 stable. This includes the following fix:
v8/v8@c408ea7
Make AstRawString deduplication encoding-agnostic.
BUG=v8:4450
LOG=N
R=hablich@chromium.org
TBR=hablich@chromium.org
Review URL: https://codereview.chromium.org/1494293003
See also: #4128
R=@nodejs/v8
/cc @vkurchatkin