doc: fix async_hooks example in api docs - #41609
Merged
nodejs-github-bot merged 1 commit intoJan 21, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Ayase-252
approved these changes
Jan 20, 2022
Ayase-252
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM if commit lint problem gets fixed.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
I did follow the doc: convention and the message title is short. Also, the commit-message-guidelines is not accessible at https://goo.gl/p2fr5Q as mentioned in the error. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
{
found: 121,
compare: '<=',
wanted: 72,
at: {
line: 1,
column: 72,
body: [
'',
'One of the Promise execution tracking examples was incorrectly requireing `exectionAsyncId` instead of `executionAsyncId`'
]
}
}
It looks like the commit body is too long. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @Ayase-252. Please 👍 to approve. |
Sorry, something went wrong.
Mesteery
approved these changes
Jan 20, 2022
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
PR-URL: #41609 Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 28, 2022
PR-URL: #41609 Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
PR-URL: #41609 Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
PR-URL: #41609 Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
PR-URL: #41609 Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Mestery <mestery@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the Promise execution tracking examples
incorrectly requires exectionAsyncId instead of executionAsyncId