doc: suggest worker threads in cluster docs - #41616
Merged
nodejs-github-bot merged 1 commit intoJan 23, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
benjamingr
approved these changes
Jan 20, 2022
Mesteery
reviewed
Jan 20, 2022
Comment thread
doc/api/cluster.md
Outdated
tniessen
force-pushed
the
doc-suggest-worker-threads-in-cluster-docs
branch
from
296d627 to
6eb266a
Compare
January 20, 2022 18:08
Trott
reviewed
Jan 20, 2022
Comment thread
doc/api/cluster.md
Outdated
tniessen
force-pushed
the
doc-suggest-worker-threads-in-cluster-docs
branch
from
6eb266a to
00ec4ea
Compare
January 20, 2022 19:32
Trott
reviewed
Jan 20, 2022
Comment thread
doc/api/cluster.md
Outdated
Trott
approved these changes
Jan 20, 2022
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with or without my suggestion
Sorry, something went wrong.
The current documentation is incorrect in that it says "A single instance of Node.js runs in a single thread," which is not true due to the addition of worker threads. This patch removes the incorrect statement and instead suggests that applications consider using worker threads when process isolation is not needed. Refs: nodejs#20876
tniessen
force-pushed
the
doc-suggest-worker-threads-in-cluster-docs
branch
from
00ec4ea to
bbe95cf
Compare
January 21, 2022 12:07
Mesteery
approved these changes
Jan 21, 2022
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
The current documentation is incorrect in that it says "A single instance of Node.js runs in a single thread," which is not true due to the addition of worker threads. This patch removes the incorrect statement and instead suggests that applications consider using worker threads when process isolation is not needed. Refs: #20876 PR-URL: #41616 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 28, 2022
The current documentation is incorrect in that it says "A single instance of Node.js runs in a single thread," which is not true due to the addition of worker threads. This patch removes the incorrect statement and instead suggests that applications consider using worker threads when process isolation is not needed. Refs: #20876 PR-URL: #41616 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
The current documentation is incorrect in that it says "A single instance of Node.js runs in a single thread," which is not true due to the addition of worker threads. This patch removes the incorrect statement and instead suggests that applications consider using worker threads when process isolation is not needed. Refs: #20876 PR-URL: #41616 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
The current documentation is incorrect in that it says "A single instance of Node.js runs in a single thread," which is not true due to the addition of worker threads. This patch removes the incorrect statement and instead suggests that applications consider using worker threads when process isolation is not needed. Refs: #20876 PR-URL: #41616 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
The current documentation is incorrect in that it says "A single instance of Node.js runs in a single thread," which is not true due to the addition of worker threads. This patch removes the incorrect statement and instead suggests that applications consider using worker threads when process isolation is not needed. Refs: #20876 PR-URL: #41616 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current documentation is incorrect in that it says "A single instance of Node.js runs in a single thread," which is not true due to the addition of worker threads (#20876).
This patch removes the incorrect statement and instead suggests that applications consider using worker threads when process isolation is not needed.