FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark test-cluster-shared-leak flaky by Trott · Pull Request #4162 · nodejs/node · GitHub

/ node Public

test: mark test-cluster-shared-leak flaky - #4162

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:double-secret-probation
Closed

test: mark test-cluster-shared-leak flaky#4162
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:double-secret-probation

Conversation

Trott commented Dec 5, 2015

Copy link
Copy Markdown
Member

test-cluster-shared-leak is flaky on Windows.

Ref: #3956

test-cluster-shared-leak is flaky on Windows.

Ref: nodejs#3956
Trott added windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Dec 5, 2015

Trott commented Dec 5, 2015

Copy link
Copy Markdown
Member Author

Also took the opportunity to alphabetize the list of flaky tests on Windows.

Copy link
Copy Markdown
Member

LGTM

2 similar comments

r-52 commented Dec 5, 2015

Copy link
Copy Markdown
Contributor

LGTM

JungMinu commented Dec 5, 2015

Copy link
Copy Markdown
Member

LGTM

mscdex added the cluster Issues and PRs related to the cluster subsystem. label Dec 5, 2015
Trott added a commit that referenced this pull request Dec 6, 2015
test-cluster-shared-leak is flaky on Windows.

Refs: #3956

PR-URL: #4162
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>

r-52 commented Dec 6, 2015

Copy link
Copy Markdown
Contributor

Thanks @Trott - Landed in afd5122

r-52 closed this Dec 6, 2015
Trott added a commit that referenced this pull request Dec 8, 2015
test-cluster-shared-leak is flaky on Windows.

Refs: #3956

PR-URL: #4162
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
rvagg mentioned this pull request Dec 17, 2015
Trott added a commit that referenced this pull request Dec 29, 2015
test-cluster-shared-leak is flaky on Windows.

Refs: #3956

PR-URL: #4162
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
test-cluster-shared-leak is flaky on Windows.

Refs: #3956

PR-URL: #4162
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
test-cluster-shared-leak is flaky on Windows.

Refs: nodejs#3956

PR-URL: nodejs#4162
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Trott deleted the double-secret-probation branch January 13, 2022 22:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL