FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

repl: make autocomplete case-insensitive by gribnoysup · Pull Request #41632 · nodejs/node · GitHub

/ node Public

repl: make autocomplete case-insensitive - #41632

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
gribnoysup:case-insensitive-autocomplete
Jun 12, 2022
ConversationCommits (1)ChecksFiles changed
Merged

repl: make autocomplete case-insensitive#41632
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
gribnoysup:case-insensitive-autocomplete

Conversation

gribnoysup commented Jan 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This changes autocomplete suggestion filter to ignore input case
when first character of the last member of the user input is lower-case
allowing for more autosuggest results shown on the screen

Fixes: #41631

nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Jan 21, 2022
gribnoysup mentioned this pull request Jan 21, 2022
Closed
gribnoysup force-pushed the case-insensitive-autocomplete branch 2 times, most recently from 7ad59a7 to 205e938 Compare January 21, 2022 17:59

benjamingr commented Jan 21, 2022

Copy link
Copy Markdown
Member

@nodejs/repl @BridgeAR

Trott commented Jan 22, 2022

Copy link
Copy Markdown
Member

Welcome, @gribnoysup, and thank you for the pull request! Can you please update the subsystem in the commit message to be repl instead of lib?

Trott changed the title lib: make autocomplete case-insensitive if user input is lowercase repl: make autocomplete case-insensitive if user input is lowercase Jan 22, 2022
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2022

nodejs-github-bot commented Jan 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42093/

nodejs-github-bot commented Jan 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42094/

gribnoysup force-pushed the case-insensitive-autocomplete branch from 205e938 to 5c98227 Compare January 23, 2022 07:48

gribnoysup commented Jan 23, 2022

Copy link
Copy Markdown
Contributor Author

Hi @Trott 👋 Sure thing, updated

benjamingr requested a review from BridgeAR January 23, 2022 08:19

nodejs-github-bot commented Jan 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42107/

nodejs-github-bot commented Jan 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42110/

nodejs-github-bot commented Jan 24, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42115/

github-actions Bot mentioned this pull request Jan 24, 2022
Open
22 tasks
addaleax removed the needs-ci PRs that need a full CI run. label Jan 24, 2022
github-actions Bot mentioned this pull request Jan 25, 2022
Open
28 tasks
targos reviewed Jan 25, 2022
View reviewed changes
Comment thread lib/repl.js Outdated
This was referenced Jan 26, 2022
Open
Open
Open
github-actions Bot mentioned this pull request Jan 29, 2022
Open
22 tasks

benjamingr commented Feb 23, 2022

Copy link
Copy Markdown
Member

Hey it looks like this has some conflicts, would you mind rebasing on top of master?

gribnoysup force-pushed the case-insensitive-autocomplete branch 2 times, most recently from bb6f57b to 3e7e3df Compare June 5, 2022 15:22
aduh95 approved these changes Jun 5, 2022
View reviewed changes
Comment thread test/parallel/test-repl-tab-complete.js Outdated
repl: make autocomplete case-insensitive
fea6adf 
This changes autocomplete suggestion filter to ignore input case
allowing for more autosuggest results shown on the screen

Fixes: nodejs#41631
gribnoysup force-pushed the case-insensitive-autocomplete branch from 3e7e3df to fea6adf Compare June 5, 2022 16:49

gribnoysup commented Jun 5, 2022

Copy link
Copy Markdown
Contributor Author

@benjamingr #41632 (comment) is resolved now if you want to take another look and proceed with this one. I'm not sure I understand the process exactly, but I'm guessing this needs request-ci label added again?

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 5, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2022

nodejs-github-bot commented Jun 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44376/

nodejs-github-bot commented Jun 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44379/

nodejs-github-bot commented Jun 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44385/

nodejs-github-bot commented Jun 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44394/

nodejs-github-bot commented Jun 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44398/

nodejs-github-bot commented Jun 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44459/

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2022
nodejs-github-bot merged commit 156365e into nodejs:master Jun 12, 2022

nodejs-github-bot commented Jun 12, 2022

Copy link
Copy Markdown
Collaborator

Landed in 156365e

gribnoysup deleted the case-insensitive-autocomplete branch June 12, 2022 11:31
danielleadams mentioned this pull request Jun 13, 2022
Merged
github-actions Bot mentioned this pull request Jun 13, 2022
Open
15 tasks
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
repl: make autocomplete case-insensitive
66d956c 
This changes autocomplete suggestion filter to ignore input case
allowing for more autosuggest results shown on the screen

Fixes: #41631

PR-URL: #41632
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
cola119 mentioned this pull request Jun 23, 2022
Merged
targos pushed a commit that referenced this pull request Jul 12, 2022
repl: make autocomplete case-insensitive
161d2c0 
This changes autocomplete suggestion filter to ignore input case
allowing for more autosuggest results shown on the screen

Fixes: #41631

PR-URL: #41632
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
repl: make autocomplete case-insensitive
bef9a36 
This changes autocomplete suggestion filter to ignore input case
allowing for more autosuggest results shown on the screen

Fixes: #41631

PR-URL: #41632
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
repl: make autocomplete case-insensitive
4e0ed94 
This changes autocomplete suggestion filter to ignore input case
allowing for more autosuggest results shown on the screen

Fixes: nodejs/node#41631

PR-URL: nodejs/node#41632
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

meixg meixg left review comments
jasnell jasnell approved these changes
Trott Trott approved these changes
addaleax addaleax approved these changes
benjamingr benjamingr approved these changes
aduh95 aduh95 approved these changes
BridgeAR Awaiting requested review from BridgeAR
+1 more reviewer
targos targos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make repl autocomplete case-insensitive

9 participants

Back | FazBrowse Home | New Git URL