doc: clarify paramater for napi_get_cb_info - #41635
Closed
mhdawson wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
tniessen
approved these changes
Jan 21, 2022
Comment thread
doc/api/n-api.md
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Unless napi_values is a real type, it should not be in backticks. This document seems to use this instead:
Suggested change
| * `[out] argv`: Array of `napi_values` to which the arguments will be | |
| * `[out] argv`: Array of `napi_value`s to which the arguments will be |
Sorry, something went wrong.
addaleax
reviewed
Jan 21, 2022
Comment thread
doc/api/n-api.md
Outdated
benjamingr
approved these changes
Jan 21, 2022
benjamingr
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with the suggestions by Anna and Tobias
Sorry, something went wrong.
NickNaso
approved these changes
Jan 22, 2022
Copy link
Copy Markdown
Member
|
paramater -> parameter |
Sorry, something went wrong.
Refs: nodejs/help#3698 Signed-off-by: Michael Dawson <mdawson@devrus.com>
Copy link
Copy Markdown
Member
Author
|
squashed and fixed commit comment. |
Sorry, something went wrong.
mhdawson
added a commit
that referenced
this pull request
Jan 25, 2022
Refs: nodejs/help#3698 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41635 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
Refs: nodejs/help#3698 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41635 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
Refs: nodejs/help#3698 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41635 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
Refs: nodejs/help#3698 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41635 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
Refs: nodejs/help#3698 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41635 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/help#3698
Signed-off-by: Michael Dawson mdawson@devrus.com