Docs: should give a descriptive information about the process.platform property & os.platform() function - #41650
Merged
nodejs-github-bot merged 1 commit intoJan 28, 2022
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
twitharshil
force-pushed
the
feature/update-doc
branch
3 times, most recently
from
6637a0c to
ea5d83f
Compare
January 22, 2022 15:45
Copy link
Copy Markdown
Member
|
Welcome, @twitharshil, and thanks for the pull request. You'll need to wrap these at 80 characters for the linter to pass. |
Sorry, something went wrong.
twitharshil
force-pushed
the
feature/update-doc
branch
from
ea5d83f to
c277908
Compare
January 23, 2022 11:15
twitharshil
force-pushed
the
feature/update-doc
branch
from
c277908 to
c7ee87e
Compare
January 23, 2022 11:22
aduh95
approved these changes
Jan 23, 2022
RaisinTen
approved these changes
Jan 23, 2022
RaisinTen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Good catch! :)
Sorry, something went wrong.
Mesteery
approved these changes
Jan 23, 2022
bnb
approved these changes
Jan 25, 2022
Copy link
Copy Markdown
Contributor
|
Thanks for the contribution 🎉 |
Sorry, something went wrong.
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
PR-URL: #41650 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
PR-URL: #41650 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
PR-URL: #41650 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
PR-URL: #41650 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process.platform & Os.platform() values are being set at the compile time for nodeJS Ref
We should be mentioning it clearly on the docs, as we do the same for the process.arch