doc: clarify that import also uses main - #41720
Merged
nodejs-github-bot merged 5 commits intoJan 30, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
benmccann
force-pushed
the
main-import
branch
from
993e211 to
71775aa
Compare
January 27, 2022 21:42
GeoffreyBooth
approved these changes
Jan 27, 2022
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
JakobJingleheimer
approved these changes
Jan 27, 2022
VoltrexKeyva
approved these changes
Jan 27, 2022
aduh95
requested changes
Jan 27, 2022
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Currently the link and the example only applies to require() (import does not support folders as modules).
I agree we should make it clearer that it defines the package entry point if there are no "exports" field, but maybe in a different paragraph.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the review! I've attempted to reword it. Let me know what you think |
Sorry, something went wrong.
aduh95
reviewed
Jan 28, 2022
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks for the new version. A few suggestions:
Sorry, something went wrong.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
done |
Sorry, something went wrong.
aduh95
approved these changes
Jan 28, 2022
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
PR-URL: #41720 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
PR-URL: #41720 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
PR-URL: #41720 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
PR-URL: #41720 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs currently make it sound like main is only used when a package is included via require(). However, if you import a package, it still uses the main field