benchmark: use Object.hasOwn() instead of hasOwnProperty() - #41769
Merged
nodejs-github-bot merged 1 commit intoJan 31, 2022
Merged
benchmark: use Object.hasOwn() instead of hasOwnProperty()#41769nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Mesteery
approved these changes
Jan 30, 2022
benjamingr
approved these changes
Jan 30, 2022
This comment has been minimized.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Sorry, something went wrong.
addaleax
approved these changes
Jan 30, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
(Ci doesn't test benchmarks so I assume this is to please commit-queue?) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
CI does test benchmarks. https://ci.nodejs.org/job/node-test-commit-linux/44499/nodes=ubuntu1804-64/console 06:46:50 ok 3382 benchmark/test-benchmark-assert 06:46:51 --- 06:46:51 duration_ms: 1.112 06:46:51 ... 06:46:51 ok 3383 benchmark/test-benchmark-async-hooks 06:46:52 --- 06:46:52 duration_ms: 0.910 06:46:52 ... 06:46:52 ok 3384 benchmark/test-benchmark-buffer 06:46:55 --- 06:46:55 duration_ms: 3.114 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
28 tasks
This was referenced Feb 1, 2022
This was referenced Feb 3, 2022
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
PR-URL: #41769 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
PR-URL: #41769 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
PR-URL: #41769 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
PR-URL: #41769 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.