doc: add note about resource type in async_hooks - #41797
Merged
nodejs-github-bot merged 5 commits intoFeb 3, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Welcome @tony-go and thanks for the pull request. Are you able to edit the first commit message? The first word after doc: should be a verb so perhaps this? doc: add note about resource type |
Sorry, something went wrong.
tony-go
force-pushed
the
async-hooks-doc-type
branch
from
cdbda7b to
e1aff5c
Compare
February 1, 2022 10:12
Copy link
Copy Markdown
Member
Author
|
Thanks for the feedback @Trott 🙌. Let me know if it's good now. |
Sorry, something went wrong.
RafaelGSS
approved these changes
Feb 1, 2022
RafaelGSS
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Qard
approved these changes
Feb 1, 2022
Trott
reviewed
Feb 1, 2022
Comment thread
doc/api/async_hooks.md
Outdated
Trott
reviewed
Feb 1, 2022
Comment thread
doc/api/async_hooks.md
Outdated
Trott
reviewed
Feb 1, 2022
Comment thread
doc/api/async_hooks.md
Outdated
Co-authored-by: Rich Trott <rtrott@gmail.com>
RaisinTen
approved these changes
Feb 2, 2022
RaisinTen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thanks!
Sorry, something went wrong.
Trott
approved these changes
Feb 2, 2022
Copy link
Copy Markdown
Member
|
@nodejs/async_hooks |
Sorry, something went wrong.
Flarna
reviewed
Feb 2, 2022
Comment thread
doc/api/async_hooks.md
Outdated
Flarna
approved these changes
Feb 2, 2022
vdeturckheim
approved these changes
Feb 2, 2022
Flarna
approved these changes
Feb 2, 2022
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
PR-URL: #41797 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
PR-URL: #41797 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
PR-URL: #41797 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
PR-URL: #41797 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone 👋
During the last Diagnostic WG meeting, the question has been raised of the type argument interface (async_hooks / init hook).
The initial demand was to document more precisely each type. But @bmeck mentions that this list of identifiers described in the documentation could arbitrarily change.
So, this pull request contains a note to explicitly tell users what is the status of these identifiers.
CC @RafaelGSS / @gireeshpunathil