doc: fix X509 CA acronym capitalization - #41841
Merged
nodejs-github-bot merged 1 commit intoFeb 4, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
Sorry, something went wrong.
Mesteery
approved these changes
Feb 3, 2022
VoltrexKeyva
approved these changes
Feb 3, 2022
cjihrig
approved these changes
Feb 3, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41841 ✔ Done loading data for nodejs/node/pull/41841 ----------------------------------- PR info ------------------------------------ Title doc: fix X509 CA acronym capitalization (#41841) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:doc-crypto-x509-ca-acronym -> nodejs:master Labels crypto, doc, fast-track Commits 1 - doc: fix X509 CA acronym capitalization Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/41841 Reviewed-By: Mestery Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41841 Reviewed-By: Mestery Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 03 Feb 2022 22:02:52 GMT ✔ Approvals: 3 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41841#pullrequestreview-872478728 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/41841#pullrequestreview-872505725 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41841#pullrequestreview-872521132 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1792519787 |
Sorry, something went wrong.
Trott
approved these changes
Feb 4, 2022
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
PR-URL: #41841 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
PR-URL: #41841 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
PR-URL: #41841 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
to danielleadams/node
that referenced
this pull request
Mar 4, 2022
PR-URL: nodejs#41841 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 8, 2022
PR-URL: #41841 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
PR-URL: #41841 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Certificate Authority (ca) to Certificate Authority (CA) since the (ca) does not refer to the name of the property but to the acronym for Certificate Authority.