FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add missing commas in cluster docs by tniessen · Pull Request #41865 · nodejs/node · GitHub

/ node Public

doc: add missing commas in cluster docs - #41865

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:doc-cluster-commas
Feb 5, 2022
Merged

doc: add missing commas in cluster docs#41865
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
tniessen:doc-cluster-commas

Conversation

tniessen commented Feb 5, 2022

Copy link
Copy Markdown
Member

No description provided.

nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Feb 5, 2022
lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 5, 2022

github-actions Bot commented Feb 5, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 5, 2022
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 5, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

DerekNonGeneric commented Feb 5, 2022
edited
Loading

Copy link
Copy Markdown
Contributor

@Trott, for doc-only changes, it seems a bit of a waste to be running the whole barrage of tests.

Not only does it waste time, but it also unnecessarily wastes electricity and may contribute to climate change.

Can we set up something to detect which type of tests we toggle based on the change reflected by the labels added?

Trott commented Feb 5, 2022

Copy link
Copy Markdown
Member

@Trott, for doc-only changes, it seems a bit of a waste to be running the whole barrage of tests.

Not only does it waste time, but it also unnecessarily wastes electricity and may contribute to climate change.

Can we set up something to detect which type of tests we toggle based on the change reflected by the labels added?

We (usually) don't run Jenkins for doc changes, so we're already running only a fraction of what we do for code changes. We have logic in some of our GitHub Actions workflows to skip in some cases. Efforts to make that more robust would be welcome.

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 5, 2022
nodejs-github-bot merged commit b8d994a into nodejs:master Feb 5, 2022

Copy link
Copy Markdown
Collaborator

Landed in b8d994a

ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
PR-URL: #41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
PR-URL: #41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
PR-URL: #41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
PR-URL: nodejs#41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
PR-URL: #41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
PR-URL: #41865
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL